prebid-server icon indicating copy to clipboard operation
prebid-server copied to clipboard
verified publisher icon prebid

Sonobi: native and currency conversion support

Open bansawbanchee opened this issue 1 year ago • 10 comments

Closed previous pull request. Put everything in one. Native and currency conversion support.

We were asked to use mtype for determining the mediatype. We currently do not support mtype from our server so I removed that function for now. Once we support it I will update our adapter.

bansawbanchee avatar Aug 27 '24 15:08 bansawbanchee

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 4122f2f9de150f9d0373ad031d50a97207b4b63d

sonobi

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:22:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:30:	MakeRequests	66.7%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:87:	makeRequest	77.8%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:111:	MakeBids	71.4%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:155:	getBidType	50.0%
total:									(statements)	69.2%

github-actions[bot] avatar Aug 27 '24 17:08 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, e42e7def4f4ea31d50bfc31003a953ef488c8da0

sonobi

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:22:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:30:	MakeRequests	66.7%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:87:	makeRequest	77.8%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:111:	MakeBids	71.4%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:155:	getBidType	50.0%
total:									(statements)	69.2%

github-actions[bot] avatar Aug 27 '24 18:08 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 944313d86abc7e00dd44c6721abc4c3aa195f001

sonobi

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:22:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:30:	MakeRequests		66.7%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:87:	makeRequest		77.8%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:111:	MakeBids		71.4%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:156:	getMediaTypeForImp	77.8%
total:									(statements)		72.1%

github-actions[bot] avatar Aug 27 '24 18:08 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, ab63a7693b7b63ac4bc86134f655306657b87869

sonobi

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:22:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:30:	MakeRequests		66.7%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:87:	makeRequest		77.8%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:111:	MakeBids		71.4%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:157:	getMediaTypeForImp	77.8%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:176:	getBidType		0.0%
total:									(statements)		66.2%

github-actions[bot] avatar Aug 27 '24 18:08 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 64dc827f211f6b030960d6f9c9bc1f09b683c4cb

sonobi

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:22:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:30:	MakeRequests		66.7%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:87:	makeRequest		77.8%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:111:	MakeBids		71.4%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:157:	getMediaTypeForImp	77.8%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:176:	getBidType		0.0%
total:									(statements)		66.2%

github-actions[bot] avatar Aug 27 '24 18:08 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, fc4db512cfff28df8d6906b43a46161d132f23b8

sonobi

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:22:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:30:	MakeRequests		66.7%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:87:	makeRequest		77.8%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:111:	MakeBids		71.4%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:157:	getMediaTypeForImp	77.8%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:176:	getBidType		0.0%
total:									(statements)		66.2%

github-actions[bot] avatar Aug 27 '24 19:08 github-actions[bot]

Hi @bansawbanchee, now that the review process has started, please push new commits instead of rebasing and force pushing to save reviewers time. Thanks!

bsardo avatar Sep 17 '24 14:09 bsardo

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, dffa78ce795db655da9aca495bef708098f0dba3

sonobi

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:22:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:30:	MakeRequests		66.7%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:87:	makeRequest		77.8%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:111:	MakeBids		75.0%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:156:	getMediaTypeForImp	77.8%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:175:	getBidType		0.0%
total:									(statements)		67.1%

github-actions[bot] avatar Sep 18 '24 17:09 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 835d0e04fdb8ee61b112b92f0063b4d08f79f4ce

sonobi

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:22:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:30:	MakeRequests		66.7%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:87:	makeRequest		77.8%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:111:	MakeBids		75.0%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:155:	getMediaTypeForImp	77.8%
total:									(statements)		73.1%

github-actions[bot] avatar Sep 19 '24 19:09 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 0c7cdde86f0ac05d3162f7058abfb32ebc75d10f

sonobi

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:22:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:30:	MakeRequests		78.6%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:88:	makeRequest		77.8%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:112:	MakeBids		75.0%
github.com/prebid/prebid-server/v2/adapters/sonobi/sonobi.go:156:	getMediaTypeForImp	77.8%
total:									(statements)		77.9%

github-actions[bot] avatar Oct 01 '24 15:10 github-actions[bot]