prebid-server icon indicating copy to clipboard operation
prebid-server copied to clipboard

New Adapter: Zentotem

Open zentotem opened this issue 1 year ago • 8 comments

Docs: https://github.com/prebid/prebid.github.io/pull/5553

zentotem avatar Aug 16 '24 23:08 zentotem

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, b3caeaa07e146bf81bfe1d4da1214f63f5eec46e

zentotem

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/zentotem/zentotem.go:19:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/zentotem/zentotem.go:26:	MakeRequests		75.0%
github.com/prebid/prebid-server/v2/adapters/zentotem/zentotem.go:58:	getMediaTypeForBid	33.3%
github.com/prebid/prebid-server/v2/adapters/zentotem/zentotem.go:72:	MakeBids		86.4%
total:									(statements)		76.1%

github-actions[bot] avatar Aug 16 '24 23:08 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, f075a6733b208a14e0212e7f915d84696afbcbb0

zentotem

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/zentotem/zentotem.go:19:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/zentotem/zentotem.go:26:	MakeRequests		75.0%
github.com/prebid/prebid-server/v2/adapters/zentotem/zentotem.go:58:	getMediaTypeForBid	0.0%
github.com/prebid/prebid-server/v2/adapters/zentotem/zentotem.go:76:	MakeBids		75.9%
total:									(statements)		66.7%

github-actions[bot] avatar Aug 20 '24 16:08 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 6f3f47c8e5fe2b6a2fdf76f9624640d8d572b82c

zentotem

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/zentotem/zentotem.go:19:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/zentotem/zentotem.go:26:	MakeRequests		75.0%
github.com/prebid/prebid-server/v2/adapters/zentotem/zentotem.go:58:	getMediaTypeForBid	85.7%
github.com/prebid/prebid-server/v2/adapters/zentotem/zentotem.go:76:	MakeBids		75.9%
total:									(statements)		77.8%

github-actions[bot] avatar Aug 20 '24 17:08 github-actions[bot]

Hello! Apologies for making some changes during the review process, but I had to change “getMediaTypeForBid”

zentotem avatar Aug 20 '24 17:08 zentotem

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 536f1183cc355a9683d5dfb1576512441b3f79c5

zentotem

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/zentotem/zentotem.go:17:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/zentotem/zentotem.go:24:	MakeRequests		83.3%
github.com/prebid/prebid-server/v2/adapters/zentotem/zentotem.go:49:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v2/adapters/zentotem/zentotem.go:62:	MakeBids		88.9%
total:									(statements)		89.2%

github-actions[bot] avatar Aug 22 '24 12:08 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, b5cb5915778a07232f8871ebc3741434d90cf6d3

zentotem

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/zentotem/zentotem.go:17:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/zentotem/zentotem.go:24:	MakeRequests		83.3%
github.com/prebid/prebid-server/v2/adapters/zentotem/zentotem.go:49:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v2/adapters/zentotem/zentotem.go:62:	MakeBids		88.9%
total:									(statements)		89.2%

github-actions[bot] avatar Aug 22 '24 13:08 github-actions[bot]

@gargcreation1992 Hello! I fixed all the comments you left above

zentotem avatar Aug 22 '24 13:08 zentotem

Hello! @onkarvhanumante kindly reminder to review =) Thanks, have a good day!

zentotem avatar Sep 17 '24 08:09 zentotem

Hi @zentotem, we recently released PBS 3.0, more specifically v3.1.0, which updates Prebid Server package import references throughout the project from v2 to v3. For example:

import (
    "github.com/prebid/prebid-server/v3/adapters"
)

As a result, please merge with master (no rebase) and then ensure all Prebid Server package import references in the files you’ve changed are v3 such that the test suite passes so we can resume reviewing. Thanks!

bsardo avatar Nov 04 '24 16:11 bsardo