Zeta Global SSP: Make sid param required

[abermanov-zeta]

Zeta Global SSP Adapter update: 'sid' is a required parameter.

[github-actions[bot]]

Code coverage summary

Note:

• Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
• Coverage summary encompasses all commits leading up to the latest one, 1887ce0d4551427198248041b84604ab1ca3e3ac

zeta_global_ssp

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/zeta_global_ssp/zeta_global_ssp.go:22:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/zeta_global_ssp/zeta_global_ssp.go:34:	MakeRequests		78.6%
github.com/prebid/prebid-server/v2/adapters/zeta_global_ssp/zeta_global_ssp.go:65:	getImpressionExt	75.0%
github.com/prebid/prebid-server/v2/adapters/zeta_global_ssp/zeta_global_ssp.go:82:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/zeta_global_ssp/zeta_global_ssp.go:87:	MakeBids		94.7%
github.com/prebid/prebid-server/v2/adapters/zeta_global_ssp/zeta_global_ssp.go:121:	getMediaTypeForBid	100.0%
total:											(statements)		88.9%

[github-actions[bot]]

Code coverage summary

Note:

• Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
• Coverage summary encompasses all commits leading up to the latest one, cf67e4daf66d04a4281f79b9e82862691b4ab47e

zeta_global_ssp

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/zeta_global_ssp/zeta_global_ssp.go:22:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/zeta_global_ssp/zeta_global_ssp.go:34:	MakeRequests		78.6%
github.com/prebid/prebid-server/v2/adapters/zeta_global_ssp/zeta_global_ssp.go:65:	getImpressionExt	75.0%
github.com/prebid/prebid-server/v2/adapters/zeta_global_ssp/zeta_global_ssp.go:82:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/zeta_global_ssp/zeta_global_ssp.go:87:	MakeBids		94.7%
github.com/prebid/prebid-server/v2/adapters/zeta_global_ssp/zeta_global_ssp.go:121:	getMediaTypeForBid	100.0%
total:											(statements)		88.9%

[abermanov-zeta]

@Sonali-More-Xandr @onkarvhanumante Could you please take a look again? thank you.

[bsardo]

With a field now being required, this is a breaking change so we should hold off on merging until the next major release so that host companies are prompted to re-review their stored requests so they can make the necessary adjustments. Tagging as 3.0.

[bsardo]

Hi @abermanov-zeta, when you have time, please resolve conflicts.

Also, we recently released PBS 3.0, more specifically v3.1.0, which updates Prebid Server package import references throughout the project from v2 to v3. For example:

import (
    "github.com/prebid/prebid-server/v3/adapters"
)

As a result, please merge with master (no rebase) and then ensure all Prebid Server package import references in the files you’ve changed are v3 such that the test suite passes so we can resume reviewing. Thanks!

[github-actions[bot]]

Code coverage summary

Note:

• Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
• Coverage summary encompasses all commits leading up to the latest one, 7704f6f106979bb3a9229c0f8b1344be89a74cb9

zeta_global_ssp

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:23:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:35:	MakeRequests		78.6%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:66:	getImpressionExt	75.0%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:83:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:88:	MakeBids		94.7%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:122:	getMediaTypeForBid	100.0%
total:											(statements)		88.9%

[abermanov-zeta]

Hi @abermanov-zeta, when you have time, please resolve conflicts.

Also, we recently released PBS 3.0, more specifically v3.1.0, which updates Prebid Server package import references throughout the project from v2 to v3. For example:

import (
    "github.com/prebid/prebid-server/v3/adapters"
)

As a result, please merge with master (no rebase) and then ensure all Prebid Server package import references in the files you’ve changed are v3 such that the test suite passes so we can resume reviewing. Thanks!

@bsardo Done. Thank you.

[abermanov-zeta]

@bsardo @Sonali-More-Xandr @SyntaxNode @onkarvhanumante @VeronikaSolovei9 Could you please review again? Thank you!

[github-actions[bot]]

Code coverage summary

Note:

• Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
• Coverage summary encompasses all commits leading up to the latest one, 00591b19def74caacae29fea40a3574866d1c635

zeta_global_ssp

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:23:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:35:	MakeRequests		78.6%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:66:	getImpressionExt	75.0%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:83:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:88:	MakeBids		94.7%
github.com/prebid/prebid-server/v3/adapters/zeta_global_ssp/zeta_global_ssp.go:122:	getMediaTypeForBid	100.0%
total:											(statements)		88.9%

[bsardo]

@abermanov-zeta do you still want to make this change? This PR has a breaking change in it as it introduces a bidder parameter as required. As a result, we had been holding off on merging it until the next major release. We are now coming up on this major release, 4.0, very soon so I wanted to check if you still wanted to make this change. If so, please merge with master to resolve the conflicts. Thanks!

[bsardo]

@abermanov-zeta can you resolve conflicts?