prebid-server icon indicating copy to clipboard operation
prebid-server copied to clipboard

New Adapter: Oraki

Open BenOraki opened this issue 1 year ago • 1 comments

DOC https://github.com/prebid/prebid.github.io/pull/5403

BenOraki avatar Aug 06 '24 07:08 BenOraki

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, b33f8d412b3a816b67d65614c2027fd14392c764

oraki

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/oraki/oraki.go:28:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/oraki/oraki.go:35:	MakeRequests	74.2%
github.com/prebid/prebid-server/v2/adapters/oraki/oraki.go:85:	makeRequest	85.7%
github.com/prebid/prebid-server/v2/adapters/oraki/oraki.go:103:	MakeBids	100.0%
github.com/prebid/prebid-server/v2/adapters/oraki/oraki.go:140:	getBidType	100.0%
total:								(statements)	85.9%

github-actions[bot] avatar Aug 06 '24 07:08 github-actions[bot]

Hi @BenOraki, we noticed that your adapter is basically the same as the Playdigo and QT adapters that were recently merged into the project, as well as the Copper6SSP adapter that is currently under review. We would like to point out that aliasing an adapter may be an option for you and is preferable if you and another bidder share the same server. You can read more about aliasing here: aliasing an adapter.

Please let us know your thoughts on whether this is a possibility for you.

bsardo avatar Aug 14 '24 15:08 bsardo

Hi @bsardo, we do not share the same server with any of the adapters you mentioned. So we cannot use aliases. This pull request is very time-sensitive, and we must get it out as soon as possible. However, I will consider some methods of code duplication reduction in the future for our adapter.

BenOraki avatar Aug 20 '24 15:08 BenOraki

@gargcreation1992 I see that this PR has been approved. Can it be merged now?

BenOraki avatar Aug 22 '24 08:08 BenOraki

Hi @BenOraki, we just got a second approval so your PR is ready to merge. I'm holding off on doing so at the moment until I fix a critical issue with the latest release and then we will merge this in.

bsardo avatar Aug 22 '24 13:08 bsardo

Hi @bsardo, why wasn’t this PR included in the last release?

BenOraki avatar Aug 30 '24 07:08 BenOraki

@BenOraki we had a freeze on merging PRs for the last release due to the critical issue mentioned earlier. This is being merged now and will be part of v2.29.0.

bsardo avatar Aug 30 '24 13:08 bsardo