prebid-server icon indicating copy to clipboard operation
prebid-server copied to clipboard

New Adapter: TradPlus

Open tradplus opened this issue 1 year ago • 1 comments

TradPlus is a leading, stable, and reliable ad monetization platform that is committed to providing global developers with fair, transparent and efficient monetization solutions. We also provide ADX and Saas ADX services. We serve 2,000+ global developers. Moreover, Our SDK has been certified by IAB Tech Lab and also joins Google Play SDK Index. And we have Information Security Management Certification.

Our advertising business spans the world. This is our official website: https://tradplusad.com/en. You can get more details about TradPlus.

this is TradPlus adapter version 1.0.

Thank!

tradplus avatar Aug 02 '24 06:08 tradplus

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 5d43c551607ed668cba76baaee90ed9ed931e16c

tradplus

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:22:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:33:	MakeRequests		100.0%
github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:41:	makeRequest		78.9%
github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:80:	getImpressionExt	71.4%
github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:98:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:106:	transform		88.2%
github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:131:	validateTradPlusExt	100.0%
github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:155:	MakeBids		88.2%
github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:186:	getMediaTypeForBid	80.0%
total:									(statements)		87.9%

github-actions[bot] avatar Aug 02 '24 06:08 github-actions[bot]

PR is inactive for more than 3-4 weeks. Therefore, closing this PR.

@tradplus, reopen this PR after addressing open comments or making code changes.

onkarvhanumante avatar Sep 04 '24 05:09 onkarvhanumante

Sorry for the delayed reply, the issue has been fixed, please reopen this PR.

tradplus avatar Sep 06 '24 02:09 tradplus

@tradplus Also please take a look on Java implementation https://github.com/prebid/prebid-server-java/pull/3361

Compile-Ninja avatar Sep 09 '24 11:09 Compile-Ninja

Already modified.

tradplus avatar Oct 10 '24 02:10 tradplus

A PR has been recreated:https://github.com/prebid/prebid-server/pull/3987

tradplus avatar Oct 16 '24 10:10 tradplus