prebid-server icon indicating copy to clipboard operation
prebid-server copied to clipboard
verified publisher icon prebid

OwnAdx: Bidder param and URL updates

Open ownAdx-prebid opened this issue 1 year ago • 5 comments

As per describe in issue #3774. Add the appropriate changes. Please verify.

ownAdx-prebid avatar Jul 17 '24 07:07 ownAdx-prebid

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, afee8157e50efa3c8189de9f5d9de46311adfac8

ownadx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/ownadx/ownadx.go:24:	getRequestData		83.3%
github.com/prebid/prebid-server/v2/adapters/ownadx/ownadx.go:52:	createBidRequest	100.0%
github.com/prebid/prebid-server/v2/adapters/ownadx/ownadx.go:57:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/ownadx/ownadx.go:66:	getImpressionExt	100.0%
github.com/prebid/prebid-server/v2/adapters/ownadx/ownadx.go:84:	MakeRequests		93.8%
github.com/prebid/prebid-server/v2/adapters/ownadx/ownadx.go:111:	groupImpsByExt		100.0%
github.com/prebid/prebid-server/v2/adapters/ownadx/ownadx.go:126:	MakeBids		100.0%
github.com/prebid/prebid-server/v2/adapters/ownadx/ownadx.go:190:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/ownadx/ownadx.go:203:	getMediaType		66.7%
total:									(statements)		92.8%

github-actions[bot] avatar Jul 24 '24 06:07 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 684d42e18030f07974d962ab27608f5fc187954d

ownadx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/ownadx/ownadx.go:24:	getRequestData		83.3%
github.com/prebid/prebid-server/v2/adapters/ownadx/ownadx.go:52:	createBidRequest	100.0%
github.com/prebid/prebid-server/v2/adapters/ownadx/ownadx.go:57:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/ownadx/ownadx.go:66:	getImpressionExt	100.0%
github.com/prebid/prebid-server/v2/adapters/ownadx/ownadx.go:84:	MakeRequests		93.8%
github.com/prebid/prebid-server/v2/adapters/ownadx/ownadx.go:111:	groupImpsByExt		100.0%
github.com/prebid/prebid-server/v2/adapters/ownadx/ownadx.go:126:	MakeBids		100.0%
github.com/prebid/prebid-server/v2/adapters/ownadx/ownadx.go:190:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/ownadx/ownadx.go:203:	getMediaType		66.7%
total:									(statements)		92.8%

github-actions[bot] avatar Jul 26 '24 06:07 github-actions[bot]

@ownAdx-prebid

PR checks are failing due formatting errors in macros.go. Run go fmt to fix it.

Run ./validate.sh --nofmt --cov --race 10
gofmt needs to be run, 1 files have issues.  Below is a list of files to review:
macros/macros.go

onkarvhanumante avatar Aug 06 '24 09:08 onkarvhanumante

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 6e7dc969ec22b1e662150d61e801549e85834e3a

ownadx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/ownadx/ownadx.go:24:	getRequestData		83.3%
github.com/prebid/prebid-server/v2/adapters/ownadx/ownadx.go:52:	createBidRequest	100.0%
github.com/prebid/prebid-server/v2/adapters/ownadx/ownadx.go:57:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/ownadx/ownadx.go:66:	getImpressionExt	100.0%
github.com/prebid/prebid-server/v2/adapters/ownadx/ownadx.go:84:	MakeRequests		93.8%
github.com/prebid/prebid-server/v2/adapters/ownadx/ownadx.go:111:	groupImpsByExt		100.0%
github.com/prebid/prebid-server/v2/adapters/ownadx/ownadx.go:126:	MakeBids		100.0%
github.com/prebid/prebid-server/v2/adapters/ownadx/ownadx.go:190:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/ownadx/ownadx.go:203:	getMediaType		66.7%
total:									(statements)		92.8%

github-actions[bot] avatar Aug 07 '24 06:08 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 97ea498426a325513acc8d5922ec6b89c8b4adb0

ownadx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/ownadx/ownadx.go:24:	getRequestData		83.3%
github.com/prebid/prebid-server/v2/adapters/ownadx/ownadx.go:52:	createBidRequest	100.0%
github.com/prebid/prebid-server/v2/adapters/ownadx/ownadx.go:57:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/ownadx/ownadx.go:66:	getImpressionExt	100.0%
github.com/prebid/prebid-server/v2/adapters/ownadx/ownadx.go:84:	MakeRequests		93.8%
github.com/prebid/prebid-server/v2/adapters/ownadx/ownadx.go:111:	groupImpsByExt		100.0%
github.com/prebid/prebid-server/v2/adapters/ownadx/ownadx.go:126:	MakeBids		100.0%
github.com/prebid/prebid-server/v2/adapters/ownadx/ownadx.go:190:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/ownadx/ownadx.go:203:	getMediaType		66.7%
total:									(statements)		92.8%

github-actions[bot] avatar Aug 07 '24 09:08 github-actions[bot]