prebid
New Adapter: Copper6SSP
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, 45a77cb8c5ece335232fba07835d38a48fef9f8c
copper6ssp
Refer here for heat map coverage report
github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:29: Builder 100.0%
github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:36: MakeRequests 76.5%
github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:91: makeRequest 85.7%
github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:109: MakeBids 100.0%
github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:146: getBidType 100.0%
total: (statements) 86.6%
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@bretg @onkarvhanumante @gargcreation1992 @bsardo @SyntaxNode @Sonali-More-Xandr please respond to this pull request
Hi @Copper6SSP. Thanks for your patience. We've been quite busy due to summer vacations and internal priorities resulting in the delay. We'll review shortly.
@bsardo thanks for answering. Do you know any deadlines for reviewing a pull request?
@bsardo thanks for answering. Do you know any deadlines for reviewing a pull request?
Hi @Copper6SSP, our pace has slowed significantly from the norm recently due to competing internal priorities and vacations. This is temporary. Peter reviewed and I will review sometime today. Sorry again for the delay.
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, 248757ea9e1e16250363d895cc0b39b7e3176973
copper6ssp
Refer here for heat map coverage report
github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:29: Builder 100.0%
github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:36: MakeRequests 77.1%
github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:93: makeRequest 85.7%
github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:111: MakeBids 100.0%
github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:147: getBidType 100.0%
total: (statements) 86.6%
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, ef0e3a3b1b240b2c1cd26671d7ab7f86e7309e91
copper6ssp
Refer here for heat map coverage report
github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:28: Builder 100.0%
github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:35: MakeRequests 88.2%
github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:91: makeRequest 85.7%
github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:109: MakeBids 100.0%
github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:145: getBidType 100.0%
total: (statements) 92.4%
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, e2eb39a1bf24e6e5bfeb8590a332cf4471de7699
copper6ssp
Refer here for heat map coverage report
github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:28: Builder 100.0%
github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:35: MakeRequests 88.2%
github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:91: makeRequest 85.7%
github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:109: MakeBids 100.0%
github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:145: getBidType 100.0%
total: (statements) 92.4%
Hi @Copper6SSP, we noticed that your adapter is basically the same as the Playdigo and QT adapters that were recently merged into the project, as well as the Oraki adapter that is currently under review. We would like to point out that aliasing an adapter may be an option for you and is preferable if you and another bidder share the same server. You can read more about aliasing here: aliasing an adapter.
Please let us know your thoughts on whether this is a possibility for you.
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, 7762ff59fda2fc0fb2ec4d8a56f366ca7058aaa9
copper6ssp
Refer here for heat map coverage report
github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:28: Builder 100.0%
github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:35: MakeRequests 88.2%
github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:91: makeRequest 85.7%
github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:109: MakeBids 100.0%
github.com/prebid/prebid-server/v2/adapters/copper6ssp/copper6ssp.go:145: getBidType 100.0%
total: (statements) 92.4%
Hi @Copper6SSP, we noticed that your adapter is basically the same as the Playdigo and QT adapters that were recently merged into the project, as well as the Oraki adapter that is currently under review. We would like to point out that aliasing an adapter may be an option for you and is preferable if you and another bidder share the same server. You can read more about aliasing here: aliasing an adapter.
Please let us know your thoughts on whether this is a possibility for you.
@bsardo Thanks for the review. Unfortunately, this does not suit us, since we have separate servers that do not belong to the above mentioned adapters.