prebid-server icon indicating copy to clipboard operation
prebid-server copied to clipboard

Published 20 hours ago • verified publisher icon prebid

New Adapter: Bidmatic

Open dkornet-ad opened this issue 1 year ago • 23 comments

dkornet-ad avatar Jun 05 '24 11:06 dkornet-ad

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 1ae1dc69c16533d1a2ff3ac502935adb1224ae24

bidmatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:23:	MakeRequests		90.6%
github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:89:	MakeBids		95.8%
github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:142:	validateImpression	81.8%
github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:200:	Builder			100.0%
total:									(statements)		90.0%

github-actions[bot] avatar Jun 05 '24 11:06 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 35c34c288d5ee5cb56fba848149d36d4424dc357

bidmatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:23:	MakeRequests		90.6%
github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:89:	MakeBids		95.8%
github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:142:	validateImpression	81.8%
github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:200:	Builder			100.0%
total:									(statements)		90.0%

github-actions[bot] avatar Jun 14 '24 09:06 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, f79759de61eedf5c21a72a48de74eab666e308d9

bidmatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:23:	MakeRequests		90.6%
github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:89:	MakeBids		95.8%
github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:142:	validateImpression	81.8%
github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:200:	Builder			100.0%
total:									(statements)		90.0%

github-actions[bot] avatar Jun 21 '24 12:06 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 1225faf260f0a092c2533ededb98dd66470e878b

bidmatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:23:	MakeRequests		90.6%
github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:89:	MakeBids		95.8%
github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:142:	validateImpression	81.8%
github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:200:	Builder			100.0%
total:									(statements)		90.0%

github-actions[bot] avatar Jun 25 '24 10:06 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 5dcf0534a8f43a1bb9b01add0e6198052346225c

bidmatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:23:	MakeRequests		90.6%
github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:89:	MakeBids		95.8%
github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:142:	validateImpression	81.8%
github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:200:	Builder			100.0%
total:									(statements)		89.9%

github-actions[bot] avatar Jun 25 '24 10:06 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 4050dae959d8d6af54f6b1372e82fc17f02251e8

bidmatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:23:	MakeRequests		90.6%
github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:89:	MakeBids		95.8%
github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:142:	validateImpression	81.8%
github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:200:	Builder			100.0%
total:									(statements)		89.9%

github-actions[bot] avatar Jun 25 '24 10:06 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 5189113cca4651e95324c471a5f969bbd1c0b651

bidmatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:23:	MakeRequests		90.6%
github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:89:	MakeBids		95.8%
github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:142:	validateImpression	81.8%
github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:200:	Builder			100.0%
total:									(statements)		89.9%

github-actions[bot] avatar Jun 25 '24 10:06 github-actions[bot]

@dkornet-ad

should update json test

  • to have request with multiple imps
  • to have multi-format imp request

onkarvhanumante avatar Jun 28 '24 11:06 onkarvhanumante

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 8df1dbef4607c77aa5ebd1991ebdf700322515db

bidmatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:23:	MakeRequests		90.6%
github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:87:	MakeBids		100.0%
github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:141:	validateImpression	86.4%
github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:199:	Builder			100.0%
total:									(statements)		92.6%

github-actions[bot] avatar Jul 02 '24 18:07 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 37e8e421fe3087b0a7164033331c3de27741afb6

bidmatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:23:	MakeRequests		90.6%
github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:87:	MakeBids		100.0%
github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:141:	validateImpression	90.0%
github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:194:	Builder			100.0%
total:									(statements)		93.7%

github-actions[bot] avatar Jul 02 '24 18:07 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, be3226ca23989cdd0ddef97c439f39d21ac42519

bidmatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:23:	MakeRequests		90.6%
github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:87:	MakeBids		100.0%
github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:141:	validateImpression	88.9%
github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:187:	Builder			100.0%
total:									(statements)		93.5%

github-actions[bot] avatar Jul 03 '24 08:07 github-actions[bot]

@dkornet-ad

Create doc PR in https://github.com/prebid/prebid.github.io repo and link doc PR in this PR's description.

Refer https://github.com/prebid/prebid.github.io/pull/5395 as example

onkarvhanumante avatar Jul 03 '24 17:07 onkarvhanumante

@onkarvhanumante we already created dev doc in https://github.com/prebid/prebid.github.io/blob/379c166b184f8a8f4dcb8500ec5bf37eb4a243c3/dev-docs/bidmatic.md

dikorn avatar Jul 12 '24 14:07 dikorn

Seems like some traction was here =)

@przemkaczmarek can we make this bidder go live ?

Thank you

GeneGenie avatar Aug 02 '24 15:08 GeneGenie

@dkornet-ad friendly ping to address comments

onkarvhanumante avatar Aug 12 '24 11:08 onkarvhanumante

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 78a72f1810915e473dffc15b7a9c7c6b12633ab0

bidmatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:23:	MakeRequests		90.6%
github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:84:	MakeBids		96.4%
github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:141:	validateImpression	88.9%
github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:187:	Builder			100.0%
total:									(statements)		92.4%

github-actions[bot] avatar Aug 12 '24 15:08 github-actions[bot]

@onkarvhanumante fixed

dkornet-ad avatar Aug 12 '24 15:08 dkornet-ad

@przemkaczmarek resolved

dkornet-ad avatar Sep 04 '24 10:09 dkornet-ad

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 04089526c0fc11019d5188333325cebbff357f5f

bidmatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:23:	MakeRequests		90.6%
github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:84:	MakeBids		96.4%
github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:141:	validateImpression	88.9%
github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:187:	Builder			100.0%
total:									(statements)		92.4%

github-actions[bot] avatar Sep 04 '24 10:09 github-actions[bot]

@przemkaczmarek kindly reminder to review =) thanks

GeneGenie avatar Sep 12 '24 14:09 GeneGenie

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 4dc9de130173a8199f93fd2e134d7e90ac9b5a56

bidmatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:23:	MakeRequests		90.6%
github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:84:	MakeBids		81.1%
github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:155:	validateImpression	88.9%
github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:201:	Builder			100.0%
total:									(statements)		86.4%

github-actions[bot] avatar Sep 13 '24 13:09 github-actions[bot]

@dkornet-ad https://github.com/prebid/prebid-server/pull/3731/files#r1762391035 one comment otherwise LGTM

onkarvhanumante avatar Sep 17 '24 05:09 onkarvhanumante

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 8a619a2090b57b02e6032ca74b6e276be4960dca

bidmatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:23:	MakeRequests		90.6%
github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:84:	MakeBids		81.1%
github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:155:	validateImpression	85.0%
github.com/prebid/prebid-server/v2/adapters/bidmatic/bidmatic.go:204:	Builder			100.0%
total:									(statements)		85.6%

github-actions[bot] avatar Sep 25 '24 10:09 github-actions[bot]