prebid-server icon indicating copy to clipboard operation
prebid-server copied to clipboard

adtelligent: ext aid type

Open dkornet-ad opened this issue 1 year ago • 1 comments

dkornet-ad avatar May 09 '24 14:05 dkornet-ad

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 8f22f9b11579c3e2df2969e56a6586c4422019c1

adtelligent

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/adtelligent/adtelligent.go:23:	MakeRequests		90.6%
github.com/prebid/prebid-server/v2/adapters/adtelligent/adtelligent.go:89:	MakeBids		95.8%
github.com/prebid/prebid-server/v2/adapters/adtelligent/adtelligent.go:142:	validateImpression	81.8%
github.com/prebid/prebid-server/v2/adapters/adtelligent/adtelligent.go:200:	Builder			100.0%
total:										(statements)		90.0%

github-actions[bot] avatar May 09 '24 14:05 github-actions[bot]

changes adressing https://github.com/prebid/Prebid.js/issues/6361

GeneGenie avatar May 15 '24 09:05 GeneGenie

@dkornet-adtelligent

PR tests are failing. Requesting to fix them

--- FAIL: TestValidParams (0.01s)
    params_test.go:22: Schema rejected adtarget params: {"aid":"123"}
    params_test.go:22: Schema rejected adtarget params: {"aid":"123","siteId":0,"bidFloor":0}
FAIL

onkarvhanumante avatar May 22 '24 08:05 onkarvhanumante

@onkarvhanumante fixed

dkornet-ad avatar May 22 '24 08:05 dkornet-ad

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, b04754f2de5ec668cc0f1a2744336fd03efad5e9

adtarget

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/adtarget/adtarget.go:23:	MakeRequests			93.3%
github.com/prebid/prebid-server/v2/adapters/adtarget/adtarget.go:84:	MakeBids			92.3%
github.com/prebid/prebid-server/v2/adapters/adtarget/adtarget.go:141:	validateImpressionAndSetExt	85.0%
github.com/prebid/prebid-server/v2/adapters/adtarget/adtarget.go:194:	Builder				100.0%
total:									(statements)			91.0%

adtelligent

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/adtelligent/adtelligent.go:23:	MakeRequests		90.6%
github.com/prebid/prebid-server/v2/adapters/adtelligent/adtelligent.go:89:	MakeBids		95.8%
github.com/prebid/prebid-server/v2/adapters/adtelligent/adtelligent.go:142:	validateImpression	81.8%
github.com/prebid/prebid-server/v2/adapters/adtelligent/adtelligent.go:200:	Builder			100.0%
total:										(statements)		90.0%

github-actions[bot] avatar Jul 16 '24 15:07 github-actions[bot]

@onkarvhanumante @Sonali-More-Xandr

dkornet-ad avatar Jul 16 '24 15:07 dkornet-ad

Hello, @onkarvhanumante can this be merged ? =)

GeneGenie avatar Aug 02 '24 15:08 GeneGenie

Hello, @onkarvhanumante can this be merged ? =)

Thanks for keeping patience with PR reviews. PR is merged now.

onkarvhanumante avatar Aug 06 '24 14:08 onkarvhanumante