prebid-server icon indicating copy to clipboard operation
prebid-server copied to clipboard

OpenWeb: updates

Open IgorKulemzin opened this issue 1 year ago • 2 comments

IgorKulemzin avatar May 08 '24 09:05 IgorKulemzin

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, a40d8168e3299a122f8137ff24d1c6db14da9923

openweb

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/openweb/openweb.go:22:	MakeRequests		81.8%
github.com/prebid/prebid-server/v2/adapters/openweb/openweb.go:47:	extractOrg		81.8%
github.com/prebid/prebid-server/v2/adapters/openweb/openweb.go:68:	MakeBids		83.3%
github.com/prebid/prebid-server/v2/adapters/openweb/openweb.go:105:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v2/adapters/openweb/openweb.go:119:	Builder			100.0%
total:									(statements)		84.8%

github-actions[bot] avatar May 08 '24 09:05 github-actions[bot]

@IgorKulemzin There is no description and the title is generic. Could you please give us an idea of the changes to the openweb adapter in this PR?

SyntaxNode avatar May 13 '24 17:05 SyntaxNode

@SyntaxNode The PR title and the description have been updated. Sorry for inconvenience.

IgorKulemzin avatar May 15 '24 15:05 IgorKulemzin

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 2d1a0378655197822504daf00427fe8d6abd9f3c

openweb

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/openweb/openweb.go:23:	MakeRequests		81.8%
github.com/prebid/prebid-server/v2/adapters/openweb/openweb.go:48:	extractOrg		76.9%
github.com/prebid/prebid-server/v2/adapters/openweb/openweb.go:73:	MakeBids		84.2%
github.com/prebid/prebid-server/v2/adapters/openweb/openweb.go:112:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v2/adapters/openweb/openweb.go:126:	Builder			100.0%
total:									(statements)		83.7%

github-actions[bot] avatar May 26 '24 10:05 github-actions[bot]

@onkarvhanumante Can you please take another look, I think all of your comments are addressed 🙏🏻

zkosanovic avatar May 29 '24 08:05 zkosanovic

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 03d44e7165abb29668e141977a26092c61f3284f

openweb

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/openweb/openweb.go:23:	MakeRequests		81.8%
github.com/prebid/prebid-server/v2/adapters/openweb/openweb.go:49:	checkExtAndExtractOrg	86.7%
github.com/prebid/prebid-server/v2/adapters/openweb/openweb.go:78:	MakeBids		84.2%
github.com/prebid/prebid-server/v2/adapters/openweb/openweb.go:117:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v2/adapters/openweb/openweb.go:131:	Builder			100.0%
total:									(statements)		86.3%

github-actions[bot] avatar Jun 11 '24 10:06 github-actions[bot]

Thanks @onkarvhanumante, can you please check again?

zkosanovic avatar Jun 11 '24 10:06 zkosanovic

@onkarvhanumante I think I addressed all of your comments, can you please check again?

zkosanovic avatar Jun 19 '24 16:06 zkosanovic

@onkarvhanumante - just a reminder if you can take a look. @Sonali-More-Xandr already approved, only your approval is needed. thanks in advance.

ErezPopperRise avatar Jun 27 '24 08:06 ErezPopperRise