prebid-server icon indicating copy to clipboard operation
prebid-server copied to clipboard

go.mod specifies go 1.20, while validation happens on go 1.19

Open justadreamer opened this issue 9 months ago • 0 comments

Background

go.mod prescribes that the whole project should be compiled with go 1.20 here: https://github.com/prebid/prebid-server/blob/master/go.mod#L3

However validate.yml workflow prescribes running it on go 1.19 here: https://github.com/prebid/prebid-server/blob/master/.github/workflows/validate.yml#L13 - this breaks the expectation of the developers who might have used features available starting go 1.20.

Also go 1.20 is not supported any more. 1.21 and 1.22 are currently supported versions according to https://endoflife.date/go.

Suggested remedy

  1. At a minimum validate.yml should be updated (and perhaps other workflows that might still require 1.19) to specify 1.20 and 1.21 (and 1.22).
  2. At a maximum requiring go 1.21 in go.mod and updating validate.yml to 1.21 and 1.22 would be ideal.

justadreamer avatar May 03 '24 13:05 justadreamer