prebid-server icon indicating copy to clipboard operation
prebid-server copied to clipboard

New Adapter: Admatic

Open bakicam opened this issue 1 year ago • 4 comments

We added s2s support for Admatic.

Docs PR: https://github.com/prebid/prebid.github.io/pull/5232

Old Pull Request reference: https://github.com/prebid/prebid-server/pull/3608

bakicam avatar May 02 '24 08:05 bakicam

The validation tests are failing because you need to format your code go fmt.

SyntaxNode avatar May 02 '24 14:05 SyntaxNode

The validation tests are failing because you need to format your code go fmt. @SyntaxNode Hello, go fmt was done. Can you check?

bakicam avatar May 02 '24 14:05 bakicam

Hi, We need for your support.

bakicam avatar May 07 '24 08:05 bakicam

Hi, We need for your support.

@bakicam to merge Prebid:master changes into Admatic-Sofware:master and update MakeRequests to return ImpIDs as mentioned below

https://github.com/prebid/prebid-server/blob/763551963dd3208dde6f9bf35b31ef76cc83814f/adapters/pubmatic/pubmatic.go#L175-L182

onkarvhanumante avatar May 13 '24 08:05 onkarvhanumante

Hello @onkarvhanumante , We made the solution.

bakicam avatar May 14 '24 06:05 bakicam

Hi @onkarvhanumante, We need for your support.

farukcam avatar May 20 '24 08:05 farukcam

Hi @onkarvhanumante, We need for your support.

Refer https://github.com/prebid/prebid-server/pull/3654#issuecomment-2106983608 to fix PR tests. let me know if any other support is needed

--- FAIL: TestJsonSamples (0.00s)
    test_json.go:128: 
        	Error Trace:	/home/runner/work/prebid-server/prebid-server/adapters/admatic/test_json.go:256
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/test_json.go:412
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/test_json.go:1[28](https://github.com/prebid/prebid-server/actions/runs/9075060288/job/24934940735?pr=3654#step:5:29)
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/test_json.go:99
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/test_json.go:76
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/path.go:445
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/path.go:467
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/path.go:467
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/path.go:5[35](https://github.com/prebid/prebid-server/actions/runs/9075060288/job/24934940735?pr=3654#step:5:36)
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/test_json.go:70
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/admatic_test.go:20
        	Error:      	Received unexpected error:
        	            	expected.ImpIDs must contain at least one imp ID
        	Test:       	TestJsonSamples
        	Messages:   	admatictest/exemplary/banner.json Expected RequestData was not returned by adapters' MakeRequests() implementation: httpRequest[0]
    test_json.go:128: 
        	Error Trace:	/home/runner/work/prebid-server/prebid-server/adapters/admatic/test_json.go:256
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/test_json.go:[41](https://github.com/prebid/prebid-server/actions/runs/9075060288/job/24934940735?pr=3654#step:5:42)2
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/test_json.go:128
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/test_json.go:99
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/test_json.go:76
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/path.go:[44](https://github.com/prebid/prebid-server/actions/runs/9075060288/job/24934940735?pr=3654#step:5:45)5
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/path.go:467
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/path.go:467
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/path.go:535
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/test_json.go:70
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/admatic_test.go:20
        	Error:      	Received unexpected error:
        	            	expected.ImpIDs must contain at least one imp ID
        	Test:       	TestJsonSamples
        	Messages:   	admatictest/exemplary/native.json Expected RequestData was not returned by adapters' MakeRequests() implementation: httpRequest[0]
    test_json.go:128: 
        	Error Trace:	/home/runner/work/prebid-server/prebid-server/adapters/admatic/test_json.go:256
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/test_json.go:412
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/test_json.go:128
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/test_json.go:99
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/test_json.go:76
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/path.go:4[45](https://github.com/prebid/prebid-server/actions/runs/9075060288/job/24934940735?pr=3654#step:5:46)
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/path.go:[46](https://github.com/prebid/prebid-server/actions/runs/9075060288/job/24934940735?pr=3654#step:5:47)7
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/path.go:467
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/path.go:535
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/test_json.go:70
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/admatic_test.go:20
        	Error:      	Received unexpected error:
        	            	expected.ImpIDs must contain at least one imp ID
        	Test:       	TestJsonSamples
        	Messages:   	admatictest/exemplary/optional-params.json Expected RequestData was not returned by adapters' MakeRequests() implementation: httpRequest[0]
    test_json.go:128: 
        	Error Trace:	/home/runner/work/prebid-server/prebid-server/adapters/admatic/test_json.go:256
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/test_json.go:412
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/test_json.go:128
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/test_json.go:99
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/test_json.go:76
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/path.go:445
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/path.go:467
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/path.go:467
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/path.go:[53](https://github.com/prebid/prebid-server/actions/runs/9075060288/job/24934940735?pr=3654#step:5:54)5
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/test_json.go:70
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/admatic_test.go:20
        	Error:      	Received unexpected error:
        	            	expected.ImpIDs must contain at least one imp ID
        	Test:       	TestJsonSamples
        	Messages:   	admatictest/exemplary/video.json Expected RequestData was not returned by adapters' MakeRequests() implementation: httpRequest[0]
    test_json.go:128: 
        	Error Trace:	/home/runner/work/prebid-server/prebid-server/adapters/admatic/test_json.go:2[56](https://github.com/prebid/prebid-server/actions/runs/9075060288/job/24934940735?pr=3654#step:5:57)
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/test_json.go:412
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/test_json.go:128
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/test_json.go:99
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/test_json.go:76
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/path.go:445
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/path.go:467
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/path.go:467
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/path.go:535
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/test_json.go:70
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/admatic_test.go:20
        	Error:      	Received unexpected error:
        	            	expected.ImpIDs must contain at least one imp ID
        	Test:       	TestJsonSamples
        	Messages:   	admatictest/supplemental/response-200-without-body.json Expected RequestData was not returned by adapters' MakeRequests() implementation: httpRequest[0]
    test_json.go:128: 
        	Error Trace:	/home/runner/work/prebid-server/prebid-server/adapters/admatic/test_json.go:256
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/test_json.go:412
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/test_json.go:128
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/test_json.go:99
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/test_json.go:76
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/path.go:445
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/path.go:4[67](https://github.com/prebid/prebid-server/actions/runs/9075060288/job/24934940735?pr=3654#step:5:68)
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/path.go:467
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/path.go:535
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/test_json.go:[70](https://github.com/prebid/prebid-server/actions/runs/9075060288/job/24934940735?pr=3654#step:5:71)
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/admatic_test.go:20
        	Error:      	Received unexpected error:
        	            	expected.ImpIDs must contain at least one imp ID
        	Test:       	TestJsonSamples
        	Messages:   	admatictest/supplemental/response-204.json Expected RequestData was not returned by adapters' MakeRequests() implementation: httpRequest[0]
    test_json.go:128: 
        	Error Trace:	/home/runner/work/prebid-server/prebid-server/adapters/admatic/test_json.go:256
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/test_json.go:412
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/test_json.go:128
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/test_json.go:99
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/test_json.go:[76](https://github.com/prebid/prebid-server/actions/runs/9075060288/job/24934940735?pr=3654#step:5:77)
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/path.go:445
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/path.go:467
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/path.go:467
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/path.go:535
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/test_json.go:70
        	            				/home/runner/work/prebid-server/prebid-server/adapters/admatic/admatic_test.go:20
        	Error:      	Received unexpected error:
        	            	expected.ImpIDs must contain at least one imp ID
        	Test:       	TestJsonSamples
        	Messages:   	admatictest/supplemental/server-error.json Expected RequestData was not returned by adapters' MakeRequests() implementation: httpRequest[0]

onkarvhanumante avatar May 22 '24 11:05 onkarvhanumante

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, f6caf06727e8b52eee5677192773f6cb3d29d74d

admatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:22:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:34:	MakeRequests		70.6%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:74:	getImpressionExt	71.4%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:93:	resolveUrl		75.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:109:	MakeBids		100.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:135:	getMediaTypeForBid	88.9%
total:									(statements)		81.0%

github-actions[bot] avatar May 23 '24 07:05 github-actions[bot]

Hi @onkarvhanumante, We fixed all problems. We need for your support.

bakicam avatar May 23 '24 07:05 bakicam

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 801a99c7153593944199383b4f6e59126ae735aa

admatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:22:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:34:	MakeRequests		70.6%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:74:	getImpressionExt	71.4%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:93:	resolveUrl		75.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:109:	MakeBids		100.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:135:	getMediaTypeForBid	88.9%
total:									(statements)		81.0%

github-actions[bot] avatar May 23 '24 09:05 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 331f4f0e78639f712c72005a4768cbd87c441955

admatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:22:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:34:	MakeRequests		70.6%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:74:	getImpressionExt	71.4%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:93:	resolveUrl		75.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:109:	MakeBids		100.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:135:	getMediaTypeForBid	88.9%
total:									(statements)		81.0%

github-actions[bot] avatar May 23 '24 12:05 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 4fb522c1810cda3841f43aa58db97ae2ab683547

admatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:22:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:34:	MakeRequests		70.6%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:74:	getImpressionExt	71.4%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:93:	resolveUrl		75.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:109:	MakeBids		100.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:135:	getMediaTypeForBid	88.9%
total:									(statements)		81.0%

github-actions[bot] avatar May 23 '24 12:05 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, ac61d1c6d744408948dd39dcaac6a8c0e8e7fbcd

admatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:22:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:34:	MakeRequests		70.6%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:74:	getImpressionExt	71.4%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:93:	resolveUrl		75.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:109:	MakeBids		93.3%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:139:	getMediaTypeForBid	88.9%
total:									(statements)		80.3%

github-actions[bot] avatar May 24 '24 08:05 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, f978cf017cf2b8099ac6bd4fd3acff500cecb456

admatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:22:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:34:	MakeRequests		70.6%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:74:	getImpressionExt	71.4%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:93:	resolveUrl		75.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:109:	MakeBids		93.8%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:139:	getMediaTypeForBid	88.9%
total:									(statements)		80.6%

github-actions[bot] avatar May 24 '24 08:05 github-actions[bot]

Hi @onkarvhanumante, Can you check again?

bakicam avatar May 24 '24 08:05 bakicam

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, f025b87c96719e5cf0ea10b9831aaedd14c709ec

admatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:22:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:34:	MakeRequests		70.6%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:74:	getImpressionExt	71.4%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:93:	resolveUrl		75.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:109:	MakeBids		93.8%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:139:	getMediaTypeForBid	88.9%
total:									(statements)		80.6%

github-actions[bot] avatar May 24 '24 12:05 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, b02724b4a3b26eeadfea49e9a4db5b9479269c6d

admatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:22:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:34:	MakeRequests		70.6%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:74:	getImpressionExt	71.4%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:93:	resolveUrl		75.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:109:	MakeBids		84.2%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:146:	getMediaTypeForBid	88.9%
total:									(statements)		78.5%

github-actions[bot] avatar May 24 '24 12:05 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 63387d3e8ffc16bb47b9be7e4c0f2be142d8342a

admatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:22:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:34:	MakeRequests		70.6%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:74:	getImpressionExt	71.4%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:93:	resolveUrl		75.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:109:	MakeBids		93.3%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:140:	getMediaTypeForBid	88.9%
total:									(statements)		80.3%

github-actions[bot] avatar May 24 '24 12:05 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 6754f1647b814620b33d073b8c8dc3d59441cc65

admatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:22:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:34:	MakeRequests		70.6%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:74:	getImpressionExt	71.4%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:93:	resolveUrl		75.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:109:	MakeBids		93.3%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:140:	getMediaTypeForBid	88.9%
total:									(statements)		80.3%

github-actions[bot] avatar May 27 '24 06:05 github-actions[bot]

Hello @onkarvhanumante I updated the fork repo. Is it ready to merge?

farukcam avatar May 27 '24 06:05 farukcam

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, c5a8a1eb59d36f635c20b8f4361dfd05efdde7c8

admatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:22:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:34:	MakeRequests		70.6%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:74:	getImpressionExt	71.4%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:93:	resolveUrl		75.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:109:	MakeBids		93.3%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:140:	getMediaTypeForBid	88.9%
total:									(statements)		80.3%

github-actions[bot] avatar May 30 '24 07:05 github-actions[bot]

Hi @onkarvhanumante, We need for your support. Thank you so much!

farukcam avatar May 30 '24 08:05 farukcam

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 61369b443f43badc902a16bf799460c389b878fe

admatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:22:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:34:	MakeRequests		70.6%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:74:	getImpressionExt	71.4%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:93:	resolveUrl		75.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:109:	MakeBids		93.3%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:140:	getMediaTypeForBid	88.9%
total:									(statements)		80.3%

github-actions[bot] avatar May 31 '24 19:05 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 41258e8f6fbe1d455500b42d62bde0247de47587

admatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:22:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:34:	MakeRequests		70.6%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:74:	getImpressionExt	71.4%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:93:	resolveUrl		75.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:109:	MakeBids		93.3%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:140:	getMediaTypeForBid	88.9%
total:									(statements)		80.3%

github-actions[bot] avatar Jun 02 '24 19:06 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 6d1197231487812e7956aa538d8828dc40c30679

admatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:22:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:34:	MakeRequests		70.6%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:74:	getImpressionExt	71.4%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:93:	resolveUrl		75.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:109:	MakeBids		93.3%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:140:	getMediaTypeForBid	88.9%
total:									(statements)		80.3%

github-actions[bot] avatar Jun 04 '24 05:06 github-actions[bot]

@Sonali-More-Xandr @onkarvhanumante Hello, I request your support for the merge. Thank you very much.

farukcam avatar Jun 04 '24 05:06 farukcam

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, fbb1c27500d9b67a5cd6ca314a9ee6a5bbe5b771

admatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:22:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:34:	MakeRequests		70.6%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:74:	getImpressionExt	71.4%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:93:	resolveUrl		75.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:109:	MakeBids		93.3%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:140:	getMediaTypeForBid	88.9%
total:									(statements)		80.3%

github-actions[bot] avatar Jun 05 '24 07:06 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 186ce42618becf5a649c52bdf04115108bf03a20

admatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:22:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:34:	MakeRequests		70.6%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:74:	getImpressionExt	71.4%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:93:	resolveUrl		75.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:109:	MakeBids		93.3%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:140:	getMediaTypeForBid	88.9%
total:									(statements)		80.3%

github-actions[bot] avatar Jun 05 '24 12:06 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, a3c2dd9a7ddf3145fd6777a34cc69df32517841f

admatic

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:22:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:34:	MakeRequests		70.6%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:74:	getImpressionExt	71.4%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:93:	resolveUrl		75.0%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:109:	MakeBids		93.3%
github.com/prebid/prebid-server/v2/adapters/admatic/admatic.go:140:	getMediaTypeForBid	88.9%
total:									(statements)		80.3%

github-actions[bot] avatar Jun 07 '24 20:06 github-actions[bot]

@Sonali-More-Xandr @onkarvhanumante Hello, I request your support for the merge. Thank you very much.

farukcam avatar Jun 10 '24 07:06 farukcam