prebid-server
prebid-server copied to clipboard
prebid
New Module: 51Degrees
Type of change
- [x] Feature
- [x] New module
Description of change
51Degrees module enriches an incoming OpenRTB request with 51Degrees Device Data.
51Degrees module sets the following fields of the device object: make, model, os, osv, h, w, ppi, pxratio - interested bidder adapters may use these fields as needed. In addition the module sets device.ext.fiftyonedegrees_deviceId to a permanent device ID which can be rapidly looked up in on premise data exposing over 250 properties including the device age, chip set, codec support, and price, operating system and app/browser versions, age, and embedded features.
The module is based on the open source 51Degrees device detection library: https://github.com/51Degrees/device-detection-go.
Integration details are specified in the modules/fiftyone_degrees/device_detection/README.md.
Maintainer contacts:
Hello. Thanks for your patience. I just want to give you a quick status update. For various reasons, we are going to need a couple more weeks before we're able to tackle this. There's a lot here so it requires a significant time investment to review, and on top of that, we may also need to perform a security review of your library and quite possibly lock the version in PBS. Stay tuned.
@bsardo - Thank you. To help make the review process more efficient for everyone I'd be happy to setup a virtual meeting with the reviewers to answer questions and clarify feedback in real time. Please let me know if this is something you or other reviewers would like to arrange.
Thanks for this review @SyntaxNode and @bsardo! The recent push addresses Scott's comments, we'll work on addressing Brian's comments tomorrow.
Hi @bsardo, thanks for the super-thorough code review! The above comments have been addressed with the latest pushes from @legendko and myself - we are ready for the next review pass :).
Hi @bsardo the latest push should address the above comments - please check. As always thank you for such a thorough review! Not sure we made it into the release, but hopefully we are close.