prebid-server icon indicating copy to clipboard operation
prebid-server copied to clipboard

Unruly: dynamic bid response array size

Open bhainesnexxen opened this issue 1 year ago • 3 comments

Though it doesn't seem to matter, we decided that the static size of 5 was unacceptable. Dynamically size the array like other adapters.

bhainesnexxen avatar Apr 25 '24 17:04 bhainesnexxen

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 2b85ca06cbdabe95ed08f6927087e9511ff9054a

unruly

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/unruly/unruly.go:20:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/unruly/unruly.go:27:	MakeRequests		84.6%
github.com/prebid/prebid-server/v2/adapters/unruly/unruly.go:53:	preProcess		72.0%
github.com/prebid/prebid-server/v2/adapters/unruly/unruly.go:93:	MakeBids		94.7%
github.com/prebid/prebid-server/v2/adapters/unruly/unruly.go:137:	getBidCount		100.0%
github.com/prebid/prebid-server/v2/adapters/unruly/unruly.go:145:	getMediaTypeForImp	92.9%
total:									(statements)		85.7%

github-actions[bot] avatar Apr 25 '24 17:04 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 9c31ea4aca9d841e8cf85a687fb991147d051294

unruly

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/unruly/unruly.go:20:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/unruly/unruly.go:27:	MakeRequests		84.6%
github.com/prebid/prebid-server/v2/adapters/unruly/unruly.go:53:	preProcess		72.0%
github.com/prebid/prebid-server/v2/adapters/unruly/unruly.go:93:	MakeBids		94.4%
github.com/prebid/prebid-server/v2/adapters/unruly/unruly.go:136:	getMediaTypeForImp	92.9%
total:									(statements)		84.7%

github-actions[bot] avatar May 13 '24 19:05 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 389f2726a8e9c7ba7eb1c7c291707004cd12e1a9

unruly

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/unruly/unruly.go:20:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/unruly/unruly.go:27:	MakeRequests		84.6%
github.com/prebid/prebid-server/v2/adapters/unruly/unruly.go:53:	preProcess		72.0%
github.com/prebid/prebid-server/v2/adapters/unruly/unruly.go:93:	MakeBids		95.2%
github.com/prebid/prebid-server/v2/adapters/unruly/unruly.go:142:	getMediaTypeForImp	92.9%
total:									(statements)		85.3%

github-actions[bot] avatar May 13 '24 19:05 github-actions[bot]