prebid-server-java icon indicating copy to clipboard operation
prebid-server-java copied to clipboard

Bidder Configuration Fixes & URL Validation

Open AntoxaAntoxic opened this issue 5 months ago โ€ข 1 comments

๐Ÿ”ง Type of changes

  • [ ] new bid adapter
  • [x] bid adapter update
  • [ ] new feature
  • [ ] new analytics adapter
  • [ ] new module
  • [ ] module update
  • [ ] bugfix
  • [ ] documentation
  • [ ] configuration
  • [ ] dependency update
  • [ ] tech debt (test coverage, refactorings, etc.)

โœจ What's the context?

  • OMS, EMX Digital, IX, Adkernel and AudienceNetwork bidders require changes in their configuration due to lacking macros in their endpoints.
  • migrating from org.apache.httpcomponents.httpclient to org.apache.httpcomponents.client5.httpclient5
  • enhancing URL validation for bidder and any other endpoints

๐Ÿง  Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

๐Ÿ”Ž New Bid Adapter Checklist

  • [ ] verify email contact works
  • [ ] NO fully dynamic hostnames
  • [ ] geographic host parameters are NOT required
  • [ ] direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • [ ] if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • [ ] cover an adapter configuration with an integration test

๐Ÿงช Test plan

How do you know the changes are safe to ship to production?

๐ŸŽ Quality check

  • [ ] Are your changes following our code style guidelines?
  • [ ] Are there any breaking changes in your code?
  • [ ] Does your test coverage exceed 90%?
  • [ ] Are there any erroneous console logs, debuggers or leftover code in your changes?

AntoxaAntoxic avatar Aug 08 '25 06:08 AntoxaAntoxic

@AntoxaAntoxic pls resolve a conflict

osulzhenko avatar Sep 19 '25 07:09 osulzhenko