prebid-server-java icon indicating copy to clipboard operation
prebid-server-java copied to clipboard

Epsilon: native support

Open johnwier opened this issue 9 months ago โ€ข 3 comments

๐Ÿ”ง Type of changes

  • [ ] new bid adapter
  • [x] bid adapter update
  • [ X ] new feature
  • [ ] new analytics adapter
  • [ ] new module
  • [ ] module update
  • [ ] bugfix
  • [ ] documentation
  • [ ] configuration
  • [ ] dependency update
  • [ ] tech debt (test coverage, refactorings, etc.)

โœจ What's the context?

Update the Epsilon bid adapter to allow Native requests This is a port from PBS https://github.com/prebid/prebid-server/pull/4277

๐Ÿง  Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

๐Ÿ”Ž New Bid Adapter Checklist

  • [ ] verify email contact works
  • [ ] NO fully dynamic hostnames
  • [ ] geographic host parameters are NOT required
  • [ ] direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • [ ] if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • [ ] cover an adapter configuration with an integration test

๐Ÿงช Test plan

How do you know the changes are safe to ship to production?

๐ŸŽ Quality check

  • [ ] Are your changes following our code style guidelines?
  • [ ] Are there any breaking changes in your code?
  • [ ] Does your test coverage exceed 90%?
  • [ ] Are there any erroneous console logs, debuggers or leftover code in your changes?

johnwier avatar Mar 31 '25 17:03 johnwier

Is it a port from PBS-Go? If yes, please link the PR.

AntoxaAntoxic avatar Apr 10 '25 12:04 AntoxaAntoxic

This is a port from PBS https://github.com/prebid/prebid-server/pull/4277

johnwier avatar Apr 14 '25 16:04 johnwier

Not sure if it's a significant issue, but in PBS-Java, epsilon is the base bidder with conversant as its alias, whereas in PBS-Go, it's the other way around.

This is related to #2654 It started as conversant and was changed to epsilon. As long as both names work I'm ok with it.

johnwier avatar Apr 17 '25 17:04 johnwier

@johnwier do you have any problems with tackling the comments? feel free to ask us anything that could be helpful for you

AntoxaAntoxic avatar May 09 '25 07:05 AntoxaAntoxic

@johnwier any updates on this one?

osulzhenko avatar May 16 '25 08:05 osulzhenko