Equativ: SmartAdserver alias with update to use mtype
🔧 Type of changes
- [X] bid adapter update
- [X] configuration
✨ What's the context?
Implementing #3608, i.e. porting this change from PBS-Go
🧠 Rationale behind the change
Keeping PBS-Java up-to-date
🧪 Test plan
Made changes to the fixtures in the integration test (added markupType to the Bid- and Auction Response) Expanded/reworked unit tests for the "makeBids" method, which was affected by the changes.
🏎 Quality check
- [ ] Are your changes following our code style guidelines?
- [ ] Are there any breaking changes in your code?
- [ ] Does your test coverage exceed 90%?
- [x] Are there any erroneous console logs, debuggers or leftover code in your changes?
- I tried to consult the code-style file while making the changes and made sure that
mvn validateis happy, but I might have missed something, pls let me know if I have to make any changes. - The changes don't seem to be breaking to me. Please correct me if I'm wrong.
Hello everyone. I am going on vacation until February so I won't be able to react to any responses here. If this PR can wait until then, I will happily finish it in February. If not, I kindly ask @bretg to assign the Issue/PR to someone else, if any changes are required.
@EmilNadimanov is it ready for review?
@osulzhenko it is. Am I supposed to mark it with a tag or something like that?
@EmilNadimanov No need—if it doesn't contain "WIP" or "draft," it will be considered ready. I was just confused by the message, which is why I decided to ask. The PR will be reviewed soon.
Required update based on the comments
Thanks for reviewing. I will get to it sooner or later, I am currently quite busy with our internal work. Sorry for that.
@CTMBNara I've made the requested changes. Sorry that it took so long.