prebid-server-java icon indicating copy to clipboard operation
prebid-server-java copied to clipboard

Equativ: SmartAdserver alias with update to use mtype

Open EmilNadimanov opened this issue 11 months ago • 6 comments

🔧 Type of changes

  • [X] bid adapter update
  • [X] configuration

✨ What's the context?

Implementing #3608, i.e. porting this change from PBS-Go

🧠 Rationale behind the change

Keeping PBS-Java up-to-date

🧪 Test plan

Made changes to the fixtures in the integration test (added markupType to the Bid- and Auction Response) Expanded/reworked unit tests for the "makeBids" method, which was affected by the changes.

🏎 Quality check

  • [ ] Are your changes following our code style guidelines?
  • [ ] Are there any breaking changes in your code?
  • [ ] Does your test coverage exceed 90%?
  • [x] Are there any erroneous console logs, debuggers or leftover code in your changes?

  1. I tried to consult the code-style file while making the changes and made sure that mvn validate is happy, but I might have missed something, pls let me know if I have to make any changes.
  2. The changes don't seem to be breaking to me. Please correct me if I'm wrong.

EmilNadimanov avatar Jan 15 '25 15:01 EmilNadimanov

Hello everyone. I am going on vacation until February so I won't be able to react to any responses here. If this PR can wait until then, I will happily finish it in February. If not, I kindly ask @bretg to assign the Issue/PR to someone else, if any changes are required.

EmilNadimanov avatar Jan 15 '25 16:01 EmilNadimanov

@EmilNadimanov is it ready for review?

osulzhenko avatar Feb 19 '25 15:02 osulzhenko

@osulzhenko it is. Am I supposed to mark it with a tag or something like that?

EmilNadimanov avatar Feb 19 '25 19:02 EmilNadimanov

@EmilNadimanov No need—if it doesn't contain "WIP" or "draft," it will be considered ready. I was just confused by the message, which is why I decided to ask. The PR will be reviewed soon.

osulzhenko avatar Feb 21 '25 09:02 osulzhenko

Required update based on the comments

osulzhenko avatar Mar 07 '25 09:03 osulzhenko

Thanks for reviewing. I will get to it sooner or later, I am currently quite busy with our internal work. Sorry for that.

EmilNadimanov avatar Mar 26 '25 10:03 EmilNadimanov

@CTMBNara I've made the requested changes. Sorry that it took so long.

EmilNadimanov avatar May 23 '25 09:05 EmilNadimanov