prebid-server-java icon indicating copy to clipboard operation
prebid-server-java copied to clipboard

Consumable Adapter - Rewrite to support full ORTB from GO

Open SuprPhatAnon opened this issue 1 year ago • 8 comments

https://github.com/prebid/prebid-server-java/issues/2865

Full rewrite of Adapter and to match the version in Go

SuprPhatAnon avatar Jan 24 '24 14:01 SuprPhatAnon

@SuprPhatAnon do you have anything else to add in this PR, or you are done here?

@VeryExtraordinaryUsername This PR is complete

SuprPhatAnon avatar Feb 09 '24 12:02 SuprPhatAnon

Hey @SuprPhatAnon, may I ask you to resolve the conflicts?

AntoxaAntoxic avatar Apr 02 '24 12:04 AntoxaAntoxic

@AntoxaAntoxic Thank you for the feedback. I can work on getting these changes made. May I ask what changed since this was previously approved and just need some conflicts resolved before?

SuprPhatAnon avatar Apr 03 '24 18:04 SuprPhatAnon

@SuprPhatAnon Usually a PR is required to be reviewed twice. In other words, approved by at least two people. This is default practice.

AntoxaAntoxic avatar Apr 04 '24 06:04 AntoxaAntoxic

@AntoxaAntoxic All changes have been made. Waiting for your approval

SuprPhatAnon avatar Apr 17 '24 21:04 SuprPhatAnon

@AntoxaAntoxic Excellent! Thanks! what is the next stop to getting this merged in

SuprPhatAnon avatar Apr 24 '24 15:04 SuprPhatAnon

It's a merge-freeze stage now before the next major release.

AntoxaAntoxic avatar Apr 25 '24 11:04 AntoxaAntoxic

This update was a simple rebase from the current master branch

SuprPhatAnon avatar May 22 '24 12:05 SuprPhatAnon

Is there anything else that we need to do in order for this to be merged and included in the next release? We were approved but not merged into the recent 3.0.0 release. Thank you.

travisbeale avatar May 22 '24 13:05 travisbeale

@travisbeale We tried not to include major bidder changes inside 3.0.

But this PR will be part of the upcoming 3.1 release

SerhiiNahornyi avatar May 22 '24 14:05 SerhiiNahornyi