prebid-mobile-ios icon indicating copy to clipboard operation
prebid-mobile-ios copied to clipboard

Dr. Prebid does not build in 2.1.0

Open ourcraig opened this issue 1 year ago • 3 comments

Describe the bug Dr. Prebid does not build in 2.1.0. When trying to build and run in iOS Simulator, Dr. Prebid throws various errors concerning undeclared identifiers e.g.

  • Use of undeclared identifier 'GenderFemale'; did you mean 'PBMGenderFemale'? in PBVPrebidSDKValdiator -setPrebidTargetingParams
  • Use of undeclared identifier 'kGADAdSizeFluid'; did you mean 'GADAdSizeFluid'? in PBVLineItemsSetupValidator - startTest

When all undeclared identifiers are fixed based on Xcode suggestions, a new error appears during build:

  • Exception NSException * "The Google Mobile Ads SDK was initialized without an application ID. Google AdMob publishers, follow instructions at https://googlemobileadssdk.page.link/admob-ios-update-plist to set a valid application ID. Google Ad Manager publishers, follow instructions at https://googlemobileadssdk.page.link/ad-manager-ios-update-plist." 0x0000600002da4fc0

To Reproduce Steps to reproduce the behavior:

  1. Download latest stable release from https://github.com/prebid/prebid-mobile-ios/releases/tag/2.1.0
  2. Extract prebid-mobile-ios-2.1.0.zip
  3. Run pod install in prebid-mobile-ios-2.1.0 directory
  4. Open PrebidMobile.xcworkspace
  5. Set Scheme to Dr.Prebid
  6. Set Destination to anything under iOS Simulator
  7. Run and build will fail

Expected behavior I expect the Dr. Prebid application to build and run successfully on iOS Simulator

Screenshots Screen Shot 2023-05-01 at 5 50 10 pm Screen Shot 2023-05-01 at 5 45 02 pm

Desktop (please complete the following information):

  • OS: macOS Monterey 12.6

Smartphone (please complete the following information):

  • Device: iOS Simulator
  • Version 14.2 (986.5)

ourcraig avatar May 01 '23 07:05 ourcraig

Hi @ourcraig ! This app is extremely outdated and it hasn't been supported for years.

@mmullin do you have any plans to restore and develop this app? If not it make sense to remove it.

YuriyVelichkoPI avatar May 02 '23 12:05 YuriyVelichkoPI

@YuriyVelichkoPI do we still need to have a discussion to remove this?

jsligh avatar Jun 03 '24 14:06 jsligh

Yes, I think @alexsavelyev or @mmullin should approve removal (or restoring). We talked about removing it, but it's still better to make a note before committing it.

YuriyVelichkoPI avatar Jun 03 '24 16:06 YuriyVelichkoPI