prebid-mobile-android icon indicating copy to clipboard operation
prebid-mobile-android copied to clipboard

adUnit?.pbAdSlot creates "adSlot" key and not pbAdSlot.

Open rBeefrz opened this issue 1 year ago • 3 comments

Describe the bug adUnit?.pbAdSlot defines 'adslot' and not 'pbadslot'.

To Reproduce Steps to reproduce the behavior:

  1. Prebid-mobile-android-master
  2. Modify one of the gam original activities (say GamOriginalApiDisplayBanner300x250) and add:
   adUnit?.gpid = "/21808260008/prebid_demo_app_original_api_banner_300x250_order"
   adUnit?.pbAdSlot = "/21808260008/prebid_demo_app_original_api_banner_300x250_order"
  1. Run PrebidDemoKotlin & retrieve the request for the 300x250 banner.

Expected behavior Unless i'm very much mistaken we expect pbAdSlot to define pbadslot in the imp[].ext and not 'adslot', as per here.

Screenshots image

image

Additional context Add any other context about the problem here.

rBeefrz avatar Dec 16 '24 08:12 rBeefrz

@OlenaPostindustria please, check the iOS behaviour.

YuriyVelichkoPI avatar Dec 16 '24 08:12 YuriyVelichkoPI

@YuriyVelichkoPI, iOS SDK creates adslot key as well.

OlenaPostindustria avatar Dec 16 '24 08:12 OlenaPostindustria

@OlenaPostindustria @ValentinPostindustria let's fix it in following way

If the publisher uses property pbAdSlot - add the imp[].ext.data.pbadslot field to the request.

Don't remove the current adslot field from the request. Add warning log message: "Prebid SDK will stop sending imp[].ext.data.adslot" field soon. If you still need it, add a comment to: https://github.com/prebid/prebid-mobile-android/issues/810."

YuriyVelichkoPI avatar Dec 16 '24 10:12 YuriyVelichkoPI