prebid-mobile-android icon indicating copy to clipboard operation
prebid-mobile-android copied to clipboard

AdViewUtils.findPrebidCreativeSize pollutes logcat with an unnecessary warning when no size object found

Open justadreamer opened this issue 1 year ago • 2 comments

Describe the bug If Prebid creative loses and some other creative served AdViewUtils.findPrebidCreativeSize would fail to find hb_size:<size> in the creative and would log a warning:

errorCode:240 errorDescription:The HTML doesn't contain a size object

The logging happens here.

However this is not an error per se - the creative may or may not contain hb_size. If it does not contain a size object - it simply means it is not a Prebid Universal Creative. Thus it should be at max an info level message, not a warning level and it should read: The HTML does not appear to be a Prebid Universal Creative, as it does not contain an hb_size snippet.

To Reproduce Steps to reproduce the behavior:

  1. Load and render any banner creative (a test ad in Google Mobile Ads SDK would do) that would be not a universal creative
  2. Call AdViewUtils.findPrebidCreativeSize on the bannerView
  3. Observe a warning message logged

Expected behavior The info level message as suggested above is logged.

Screenshots image

Smartphone (please complete the following information): Any Android.

justadreamer avatar Dec 12 '23 14:12 justadreamer

@justadreamer is this still an issue?

jsligh avatar Jun 03 '24 15:06 jsligh

Hi @jsligh yes this is still an issue, but very minor (cosmetics), can be handled with low priority.

justadreamer avatar Jun 05 '24 14:06 justadreamer