prebid-mobile-android icon indicating copy to clipboard operation
prebid-mobile-android copied to clipboard

Provide Getter/Setter methods to the `displaymanager` and `displaymanagerver` objects

Open takenorim opened this issue 1 year ago • 7 comments

I know those objects are dropped intentionally per the #551. However, in terms of profitability, those OpenRTB objects are relevant to some bidders.

Default value (null for the Original API integration, hard-coded values (prebid-mobile and SDK version) for other integrations) is fine. But, it's worthwhile to app developers to have capability to setup those flags whatever they want.

takenorim avatar Aug 22 '23 01:08 takenorim

Hi @takenorim ! Thanks for the report!

#551 was not about removing the values but about sending only relevant ones. In the case of Original API, the Prebid SDK doesn't know anything about the rendering engine. It can be GMA SDK, IMA SDK, or custom SDK. So by default, the Prebid SDK should send nothing for these fields.

As for me, providing publishers the ability to set these properties via SDK configs makes sense.

It can be implemented in two ways:

Since we have the feature request for ORTB parameters, I'd suggest moving this way. It's more time-consuming, though.

@takenorim:

  • how urgent is this request?
  • have you tried to set displaymanager and displaymanagerver right in the stored impression on PBS? (like a hotfix)

@alexsavelyev @mmullin, the committee should prioritize and choose the implementation approach for this ticket.

YuriyVelichko avatar Aug 22 '23 07:08 YuriyVelichko

Hey @YuriyVelichko ! Thanks for your prompt feedback.

Since we have the feature request for ORTB parameters, I'd suggest moving this way. It's more time-consuming, though.

This way sounds reasonable.

Either way, app developers need to upgrade Prebid SDK, change app source codes, re-build app, and push it to the app store. So, entire process will be time-consuming. Then, I believe more generic way (supporting oRTB params) would be preferable way for everyone.

have you tried to set displaymanager and displaymanagerver right in the stored impression on PBS? (like a hotfix)

Not yet. I'm waiting for feedback from my PBS team whether our production PBS cluster can support such custom oRTB objects at imp-level SRID.

takenorim avatar Aug 23 '23 07:08 takenorim

Hi @YuriyVelichko I have a client here who requested it too as they're seeing uplift in spend from some partners whenever this field is present in requests. Would we be able to prio it?

chakersaloumi avatar Sep 01 '23 07:09 chakersaloumi

@alexsavelyev @mmullin, we should discuss it on the next backlog grooming call. (Mon, Sep 4th)

YuriyVelichkoPI avatar Sep 01 '23 08:09 YuriyVelichkoPI

Hi @YuriyVelichko I also have a client who requested this as well for the same reason as @chakersaloumi calls out. Has there been any update on this?

abbielamb avatar Sep 12 '23 14:09 abbielamb

The last grooming call was on Labor Day, so we didn't get a quorum. @mmullin, @alexsavelyev - double ping with the request to prioritize this issue.

YuriyVelichkoPI avatar Sep 12 '23 15:09 YuriyVelichkoPI

This should be solved with https://github.com/prebid/prebid-mobile-ios/issues/877

alexsavelyev avatar Jan 11 '24 16:01 alexsavelyev