Prebid.js icon indicating copy to clipboard operation
Prebid.js copied to clipboard

Mabidder Bid Adapter: initial adapter release

Open ecdrsvc opened this issue 2 years ago • 4 comments

Type of change

  • [x] New bidder adapter

Description of change

New prebid adapter to connect to MediaAisle demand source

  • test parameters for validating bids
{
        code: 'test_banner',
        mediaTypes: {
            banner: {
                sizes: [300, 250]
            }
        },
        bids: [{
            bidder: 'mabidder',
            params: {
                ppid: 'test'
            }
        }],
    }

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer: [email protected]
  • [x] official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

  • A link to a PR on the docs repo at https://github.com/prebid/prebid.github.io/

Other information

Documentation PR: https://github.com/prebid/prebid.github.io/pull/3962

ecdrsvc avatar Aug 16 '22 15:08 ecdrsvc

@ecdrsvc could you please take out the empty line change in the package file of this pr 🙏

ChrisHuie avatar Aug 16 '22 15:08 ChrisHuie

This pull request introduces 1 alert when merging cdf49620a5167e312e77f0c326fada8ad5cb1db3 into 91ce750022daedff8bc70f5fee94088d7a6cda18 - view on LGTM.com

new alerts:

  • 1 for Implicit operand conversion

lgtm-com[bot] avatar Aug 16 '22 15:08 lgtm-com[bot]

@ecdrsvc could you please take out the empty line change in the package file of this pr 🙏

@ChrisHuie How do I take out that change? Tried deleting the file and adding the original from the main prebid.js repository, but that change still shows up in the pr.

ecdrsvc avatar Aug 16 '22 19:08 ecdrsvc

This pull request introduces 1 alert when merging 365de6c09af16c1f5e1a9e4816a252401c7ca3cd into 91ce750022daedff8bc70f5fee94088d7a6cda18 - view on LGTM.com

new alerts:

  • 1 for Implicit operand conversion

lgtm-com[bot] avatar Aug 16 '22 19:08 lgtm-com[bot]

Hi @ecdrsvc

You have to rewrite your history to remove the commit on which you added the package-lock.json and then force-push.

There are several way to do it, but a simple one to do this is:

git reset c6c359c6 # reset your HEAD to the commit before  you added the package-lock but keep all your changes
git checkout -- package-lock.json  # remove your changes
git add <your files>
git commit 
git push --force

osazos avatar Aug 17 '22 14:08 osazos

Hi, thanks for your submission.

In addition to my comments, there is still the need to fix the package-lock issue.

After that, this should be ok.

Thanks @osazos, the updates have been made.

ecdrsvc avatar Aug 19 '22 15:08 ecdrsvc

This pull request introduces 1 alert when merging 0d450603b09d327b30ef9fbf8f277ba7bc81868b into 4a3daec6f1854f1b323140b84e8edb8e93d4b699 - view on LGTM.com

new alerts:

  • 1 for Implicit operand conversion

lgtm-com[bot] avatar Aug 19 '22 16:08 lgtm-com[bot]

This pull request introduces 1 alert when merging 52a4936dd5cbd3be67c2934287f61d6d683eb78b into 7e5548e4de15edb3b554fcd6c8a19a26c0bd36e2 - view on LGTM.com

new alerts:

  • 1 for Implicit operand conversion

lgtm-com[bot] avatar Aug 22 '22 13:08 lgtm-com[bot]

Thanks @osazos and Prebid.js team for working with us on this request. Is there is anything else needed on our end before the changes are merged? Do you have an idea on when our adapter will be available for publishers to use? Thanks again!

ecdrsvc avatar Aug 25 '22 14:08 ecdrsvc