Prebid.js icon indicating copy to clipboard operation
Prebid.js copied to clipboard

adquery Id System module: remove local storage

Open adquery opened this issue 2 years ago • 5 comments

Type of change

  • [ x] Bugfix

Description of change

We gave up on storing the id in localstorage because this caused duplicate qid

adquery avatar Aug 04 '22 18:08 adquery

@smenzer is there something apparent to you that might help this user?

patmmccann avatar Aug 04 '22 18:08 patmmccann

@adquery, is there a chance you can help me track down this issue - where are you seeing duplicate ids? Do you have a setConfig that would let me reproduce it? I think this might be related to https://github.com/prebid/Prebid.js/issues/8770 but I have so far been unable to reproduce.

dgirardi avatar Aug 04 '22 18:08 dgirardi

@smenzer is there something apparent to you that might help this user?

@patmmccann I'm not sure exactly...we've always just used the built-in storage functionality of the user id module and don't recall ever having any major issues with it.

smenzer avatar Aug 04 '22 19:08 smenzer

@dgirardi the error is not related to https://github.com/prebid/Prebid.js/issues/8770.The error is in our module adquerySystemId, because I had passed wrong parametrs and I had saved inneceserily to localstorage.The effect was like that: %7B%22qid%22%3A%22%257B%2522qid%2522%253A%2522%25257B%252522qid%252522%25253A%252522%2525257B%25252522qid%25252522%2525253A%25252522ea253fb7bc1f563cbb2d%25252522%2525257D%252522%25257D%2522%257D%22%7D .After decoding it reveals that there was json with qid {qid: 3418b020e761debe963e}.So, it is not that error

adquery avatar Aug 04 '22 19:08 adquery

Looks like this code removal broke unit tests within the userid spec file. These will need to be corrected before merging

mmoschovas avatar Aug 10 '22 15:08 mmoschovas