Prebid.js icon indicating copy to clipboard operation
Prebid.js copied to clipboard

Published 20 hours ago • verified publisher icon prebid

Adriver Bid and Id Modules: buyerid bug fix

Open m-oranskaya opened this issue 2 years ago • 4 comments

Type of change

  • [x] Bugfix

Description of change

Fixed bug with getting buyerid and fixing tests

Maintainer email: [email protected]

Other information

Please add adriver to the generation page https://docs.prebid.org/download.html in the "User ID Modules" section. Because during the last update, the adriverIdSystem module was added, but it was not added on the generation page

m-oranskaya avatar Aug 02 '22 14:08 m-oranskaya

@m-oranskaya I will follow-up on the download page to add adriver

ChrisHuie avatar Aug 04 '22 12:08 ChrisHuie

We think that error in the CircleCI tests is not related to our changes. Shall we do something else to get our changes approved?

m-oranskaya avatar Aug 10 '22 13:08 m-oranskaya

Hi, why do you send id's from other modules ? I don't think this behavior is expected here. cc @patmmccann

(the CI error is not related to your changes, I confirm)

osazos avatar Aug 10 '22 20:08 osazos

We have made the necessary changes, is there anything else we need to do to get the Pull Request approved?

m-oranskaya avatar Aug 16 '22 10:08 m-oranskaya

Could you add our userId module to download page?

m-oranskaya avatar Aug 18 '22 15:08 m-oranskaya

Could you add our userId module to download page?

@ChrisHuie ?

osazos avatar Aug 19 '22 09:08 osazos

Please tell the approximate time when you will be able to add our module on https://docs.prebid.org/download.html in the "User ID Modules" section. It is very important for us. Several clients that use prebid are looking forward to being able to generate code.

NikolaevAlexander avatar Aug 25 '22 09:08 NikolaevAlexander

Hello, @osazos, @ChrisHuie, @patmmccann ! It has been 4 months since these changes were made. When you will be able to add our module on https://docs.prebid.org/download.html in the "User ID Modules" section? It's very important for us and our customers to be able to download it from this page. Is there any problem with it? What should we do to make it happen?

NikolaevAlexander avatar Dec 14 '22 08:12 NikolaevAlexander

Hello, @osazos, @ChrisHuie, @patmmccann ! Please, help us with this problem!

NikolaevAlexander avatar Dec 20 '22 07:12 NikolaevAlexander

Hi @NikolaevAlexander,

Actually you only have your bidAdapter documented.

You have to create a new PR in https://github.com/prebid/prebid.github.io to add your user id module.

  • add dev-docs/modules/userid-submodules/adriver.md
  • update download.md

Take a look at others modules files as example.

Sorry for the response delay.

osazos avatar Dec 21 '22 05:12 osazos

Hi @osazos ! Thank you for the information.

NikolaevAlexander avatar Dec 22 '22 08:12 NikolaevAlexander