Prebid.js icon indicating copy to clipboard operation
Prebid.js copied to clipboard

ORTB Native refinements

Open bretg opened this issue 2 years ago • 3 comments

Type of issue

enhancement

Description

While updating the ORTB native docs, generated a list of proposed changes/enhancements:

1. Auto Asset ID generation

ORTB requires asset IDs, but this is mainly for linking response assets to the request assets. At one point we discussed having PBJS fill in missing asset IDs. Something like:

  • scan the publisher-defined assets for any of them that have an ID. If the ID was specified as anything other a positive number, log a major error and stop processing.
  • let base asset ID=highest existing asset ID + 1. If there were none, then start with 1.
  • iterate back through the assets and assign asset IDs to any of them that don't already have IDs. Skip any that already have IDs

2. Deprecate the sendTargetingKeys flag

This is the old option that tells Prebid to send all the hb_native KVPs to the adserver. That shouldn't happen anymore now that we have better ways to transmit the asset data at render time.

Proposal:

  1. if both sendTargetingKeys and ortb are specified in adunit.mediatypes.native, it's a major error. (do we cancel the whole auction or just the adunit when there's an error like this?)
  2. when ortb is specified, treat sendTargetingKeys as false.

3. Deprecate Native "types"

'Type' is a sort of 'macro' introduced in an early version of PBJS that expands to a set of assets. This is Prebid-only behavior meant to be friendly, but doesn't fit well with the ORTB approach.

Proposal: if both 'types' and 'ortb' are specified in adunit.mediatypes.native, it's a major error. (do we cancel the whole auction or just the adunit when there's an error like this?)

Heads up @muuki88 , @patmmccann , @dgirardi, @musikele

bretg avatar Aug 01 '22 15:08 bretg

I think it is fair to sever 4 from this and continue to track on #6695

patmmccann avatar Aug 01 '22 15:08 patmmccann

Ok, removed the 4th item.

bretg avatar Aug 02 '22 00:08 bretg

Hi @bretg , regarding point n.1, Asset IDs are also used in templates to specify the assets (for example, ##hb_native_asset_id_1##). When using ORTB assets, only the publisher knows what ID is associated with titles, images, or data. So, if we auto-generate them, or if we make this link implicit, we'll loose this connection between the request assets and the template.

No problem in checking that it's a positive number.

I'm fine with points 2 and 3.

musikele avatar Aug 03 '22 15:08 musikele

PMC: Agree on 1, implement it. for 2 and 3, mark these features as deprecated and log a message to the console if they are used.

lcorrigall avatar May 08 '24 16:05 lcorrigall

closed with 11481

dgirardi avatar May 16 '24 17:05 dgirardi