Prebid.js icon indicating copy to clipboard operation
Prebid.js copied to clipboard

Prebid Core: Restore use of server-side adapter without client-side adapter

Open jorgeluisrocha opened this issue 3 years ago • 6 comments

Type of change

  • Bugfix

Description of change

Fixes a bug that requires client-side adapter codes to be imported for server-side bidding. This obviates the need to import client-side adapter specifications. Additionally, this resolves the regression introduced by the original version of this PR found in #7662.

Other information

Issue: #6361 Issue: #6388

jorgeluisrocha avatar Nov 15 '21 18:11 jorgeluisrocha

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jan 08 '22 23:01 stale[bot]

@jorgeluisrocha following up on this pr. Are you still working on this pr to add a little test coverage?

ChrisHuie avatar Jan 25 '22 16:01 ChrisHuie

@karimMourra can you weigh in here? this seems stalled

patmmccann avatar Apr 15 '22 15:04 patmmccann

Hi @patmmccann , Jorge will add unit tests to this PR when he has enough bandwidth

karimMourra avatar Apr 18 '22 20:04 karimMourra

@karimMourra @jorgeluisrocha following up on this pr. Is it okay if I close this pr for now and it is just reopened when bandwidth provides

ChrisHuie avatar Jun 28 '22 14:06 ChrisHuie

This PR is related to issue https://github.com/prebid/Prebid.js/issues/6361

For the record, client-side bid adapters defines 4 things that could be important to server behavior:

  1. MediaTypes
  2. Aliases
  3. GVLID
  4. transformBidParams

#1-3 are ok -- either they can be defined in s2sConfig as needed or they're also defined server-side.

A few bidAdapters do however, require transformBidParams() Those ones may not work well if the client-side adapter is not present.

bretg avatar Jun 30 '22 19:06 bretg

This was incidentally fixed in #8357; just verified that no client side adapters are needed now for interfacing with Server.

dgirardi avatar Sep 07 '22 14:09 dgirardi