Prebid.js icon indicating copy to clipboard operation
Prebid.js copied to clipboard

Marking used bids for video

Open patmmccann opened this issue 4 years ago • 9 comments

Type of issue

Feature request

Description

https://github.com/prebid/Prebid.js/pull/5481 adds module support for detecting if a video bid won instead of just set targeting. https://github.com/prebid/Prebid.js/pull/2777 adds a function for publishers to mark bids as used upon set targeting. It seems with the addition of #5481 that a logical extension of #2777 is to add MarkRenderedBidsAsUsed instead of mark winning bids as used. The logic might look very similar to mark winning but with the additional render check from #5481 . However, it isn't obvious how we would make a global function export like this depend on a module.

patmmccann avatar Sep 03 '20 16:09 patmmccann

@monis0395 / @monisq would you like to fix this too? It was dependent on your fix #5481

pm-harshad-mane avatar Sep 24 '20 23:09 pm-harshad-mane

Hi @pm-harshad-mane, I am blocked for my sprint, will check after 9th October

monis0395 avatar Sep 25 '20 10:09 monis0395

@monis0395 did you ever make any headway here? @karimMourra is this something easily addressed in the new video work we're doing?

gglas avatar Mar 01 '21 16:03 gglas

@gglas I believe so. We would like the Video Module to emit ad rendering events such as adImpression which would indicate if the winning bid's ad creative was rendered.

karimMourra avatar Mar 02 '21 03:03 karimMourra

will be addressed in #6271

patmmccann avatar Mar 04 '21 17:03 patmmccann

@karimMourra should we re-open this or do we plan to put the video module stuff back up?

patmmccann avatar Aug 16 '22 16:08 patmmccann

re-opening so i dont forget

patmmccann avatar Aug 16 '22 19:08 patmmccann

@patmmccann I reopened the PR ; we can keep this issue opened until the PR gets merged https://github.com/prebid/Prebid.js/pull/8858

karimMourra avatar Aug 17 '22 19:08 karimMourra

thanks!!

patmmccann avatar Aug 17 '22 20:08 patmmccann