Adding a new bid adapter (oprx) for OptimizeRx

[suruvu]

Adding new prebid adapter oprx for OptimizeRx

Type of change

• [ ] Bugfix

• [ ] Feature

• [x] New bidder adapter

• [ ] Updated bidder adapter

• [ ] Code style update (formatting, local variables)

• [ ] Refactoring (no functional changes, no api changes)

• [ ] Build related changes

• [ ] CI related changes

• [ ] Does this change affect user-facing APIs or examples documented on http://prebid.org?

• [ ] Other

Description of change

Other information

[github-actions[bot]]

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/lane4BidAdapter.js has 25 duplicated lines with modules/oprxBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

[patmmccann]

Why didn't you just alias the lane4 bidder?

[suruvu]

Why didn't you just alias the lane4 bidder

We just want to try and see prebid.js as a bidder. Thats why just copied the code from one bidder. Is that not correct? If so, we will change the code as needed. Thanks for the quick response.

[github-actions[bot]]

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/lane4BidAdapter.js has 25 duplicated lines with modules/oprxBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

[patmmccann]

How did you choose lane4? There are several much better implementations, eg rixengine

[suruvu]

THank you so much. Will take the reference of rixengine

[github-actions[bot]]

Tread carefully! This PR adds 9 linter errors (possibly disabled through directives):

• modules/oprxBidAdapter.js (+9 errors)

[github-actions[bot]]

Tread carefully! This PR adds 9 linter errors (possibly disabled through directives):

• modules/oprxBidAdapter.js (+9 errors)

[github-actions[bot]]

Tread carefully! This PR adds 9 linter errors (possibly disabled through directives):

• modules/oprxBidAdapter.js (+9 errors)

[github-actions[bot]]

Tread carefully! This PR adds 1 linter error (possibly disabled through directives):

• modules/oprxBidAdapter.js (+1 error)

[github-actions[bot]]

Tread carefully! This PR adds 1 linter error (possibly disabled through directives):

• modules/oprxBidAdapter.js (+1 error)

[patmmccann]

this is looking pretty good, you still need unit tests

[suruvu]

Hi, do you need anything else from me for the approval to commit the code for new bidder adapter? Please let me know.

[suruvu]

Thank you for the approval

[suruvu]

When can I see the OptimizeRx's new adapter "oprx" in prebid.js download page?

[suruvu]

When can I see the OptimizeRx's new adapter "oprx" in prebid.js download page?

Hi, Still I cants see the OptimizeRx (oprx), new bidder adapter in the download page. Do I need to do anything else for that?