Prebid.js icon indicating copy to clipboard operation
Prebid.js copied to clipboard

Nexverse Bid Adapter : initial relese

Open anand-nexverse opened this issue 1 year ago • 6 comments

Type of change

  • [x] Bugfix

  • [x] Feature

  • [x] New bidder adapter

  • [ ] Updated bidder adapter

  • [ ] Code style update (formatting, local variables)

  • [ ] Refactoring (no functional changes, no api changes)

  • [ ] Build related changes

  • [ ] CI related changes

  • [ ] Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • [ ] Other

Description of change

Other information

anand-nexverse avatar Oct 07 '24 10:10 anand-nexverse

Tread carefully! This PR adds 4 linter errors (possibly disabled through directives):

  • modules/nexverseBidAdapter.js (+4 errors)

github-actions[bot] avatar Oct 07 '24 10:10 github-actions[bot]

updated function build request

anand-nexverse avatar Oct 07 '24 10:10 anand-nexverse

Can you please add docs to our docs repo for this pr -> https://github.com/prebid/prebid.github.io/pulls

Also, if you pull in master tests should be fixed

ChrisHuie avatar Oct 07 '24 13:10 ChrisHuie

Tread carefully! This PR adds 4 linter errors (possibly disabled through directives):

  • modules/nexverseBidAdapter.js (+4 errors)

github-actions[bot] avatar Oct 08 '24 17:10 github-actions[bot]

Tread carefully! This PR adds 4 linter errors (possibly disabled through directives):

  • modules/nexverseBidAdapter.js (+4 errors)

github-actions[bot] avatar Oct 08 '24 18:10 github-actions[bot]

docs PR https://github.com/prebid/prebid.github.io/pull/5640

bretg avatar Oct 10 '24 19:10 bretg

Tread carefully! This PR adds 1 linter warning (possibly disabled through directives):

  • libraries/nexverseUtils/index.js (+1 warning)

github-actions[bot] avatar Nov 20 '24 05:11 github-actions[bot]

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

github-actions[bot] avatar Nov 20 '24 11:11 github-actions[bot]

Tread carefully! This PR adds 3 linter errors (possibly disabled through directives):

  • libraries/nexverseUtils/index.js (+3 errors)

github-actions[bot] avatar Nov 20 '24 11:11 github-actions[bot]

Tread carefully! This PR adds 2 linter errors (possibly disabled through directives):

  • libraries/nexverseUtils/index.js (+2 errors)

github-actions[bot] avatar Nov 20 '24 11:11 github-actions[bot]