Prebid.js icon indicating copy to clipboard operation
Prebid.js copied to clipboard
verified publisher icon prebid

Adkernel Bid Adapter: Remove FelixAds

Open lyricwulf opened this issue 1 year ago • 1 comments

NOTE I am NOT the maintainer for AdKernel nor a representative of FelixAds, just noticed a potential duplicated alias while analyzing the codebase. Requires approval from @felixads @SmartHubSolutions @ckbo3hrk

Type of change

  • [X] Bugfix
  • [X] Updated bidder adapter

Description of change

Remove possibly incorrect alias (currently felixads is aliased to both adkernel and smarthub).

What is the expected behavior of two bid adapters listing the same code as an alias? Is it considered a bug, or should both bid adapters send requests?

Other information

Reason I believe this alias may no longer be valid is since #12072, and docs for FelixAds were updated to smarthub bid params from adkernel's in https://github.com/prebid/prebid.github.io/pull/5521

lyricwulf avatar Sep 12 '24 02:09 lyricwulf

Wait for the final decision, we are trying to get a response from FelixAds partner

SmartHubSolutions avatar Sep 12 '24 10:09 SmartHubSolutions

This is a bug fix, we can't have two of the same alias

patmmccann avatar Nov 16 '24 20:11 patmmccann