prebid
Djax Analytic Adapter : initial release
Type of change
- [x] Feature
- [x] New Analytic bidder adapter
Description of change
Submission of new analytic adapter
Contact email of the adapter’s maintainer - [email protected]
Tread carefully! This PR adds 1 linter error (possibly disabled through directives):
modules/djaxAnalyticsAdapter.js(+1 error)
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
modules/djaxAnalyticsAdapter.jshas 127 duplicated lines withmodules/genericAnalyticsAdapter.js
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀
@dream-djaxtech Hello - you will also need to add some unit tests please.
You can see examples for _spec.js files.
