prebid
Audiencelogy Bid Adapter : Initial Release
Type of change
-
[ ] Bugfix
-
[ ] Feature
-
[x] New bidder adapter
-
[ ] Updated bidder adapter
-
[ ] Code style update (formatting, local variables)
-
[ ] Refactoring (no functional changes, no api changes)
-
[ ] Build related changes
-
[ ] CI related changes
-
[ ] Does this change affect user-facing APIs or examples documented on http://prebid.org?
-
[ ] Other
Description of change
Other information
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
modules/audiencelogyBidAdapter.jshas 34 duplicated lines withmodules/relevatehealthBidAdapter.jsmodules/audiencelogyBidAdapter.jshas 29 duplicated lines withmodules/relevatehealthBidAdapter.jsmodules/audiencelogyBidAdapter.jshas 79 duplicated lines withmodules/relevatehealthBidAdapter.js
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
modules/audiencelogyBidAdapter.jshas 8 duplicated lines withmodules/relevatehealthBidAdapter.jsmodules/audiencelogyBidAdapter.jshas 16 duplicated lines withmodules/relevatehealthBidAdapter.jsmodules/audiencelogyBidAdapter.jshas 20 duplicated lines withmodules/relevatehealthBidAdapter.jsmodules/audiencelogyBidAdapter.jshas 16 duplicated lines withmodules/relevatehealthBidAdapter.js
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
modules/audiencelogyBidAdapter.jshas 8 duplicated lines withmodules/relevatehealthBidAdapter.jsmodules/audiencelogyBidAdapter.jshas 8 duplicated lines withmodules/relevatehealthBidAdapter.jsmodules/audiencelogyBidAdapter.jshas 20 duplicated lines withmodules/relevatehealthBidAdapter.js
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀
Please add docs to -> https://github.com/prebid/prebid.github.io
Added https://github.com/prebid/prebid.github.io/pull/5457
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
modules/relevatehealthBidAdapter.jshas 21 duplicated lines withlibraries/audiencelogyUtils/bidderUtils.jsmodules/relevatehealthBidAdapter.jshas 19 duplicated lines withlibraries/audiencelogyUtils/bidderUtils.jsmodules/relevatehealthBidAdapter.jshas 10 duplicated lines withlibraries/audiencelogyUtils/bidderUtils.jsmodules/deepintentBidAdapter.jshas 6 duplicated lines withlibraries/audiencelogyUtils/bidderUtils.jsmodules/audiencelogyBidAdapter.jshas 13 duplicated lines withmodules/relevatehealthBidAdapter.jsmodules/audiencelogyBidAdapter.jshas 19 duplicated lines withmodules/relevatehealthBidAdapter.js
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
modules/relevatehealthBidAdapter.jshas 21 duplicated lines withlibraries/audiencelogyUtils/bidderUtils.jsmodules/deepintentBidAdapter.jshas 6 duplicated lines withlibraries/audiencelogyUtils/bidderUtils.jsmodules/audiencelogyBidAdapter.jshas 13 duplicated lines withmodules/relevatehealthBidAdapter.jsmodules/audiencelogyBidAdapter.jshas 19 duplicated lines withmodules/relevatehealthBidAdapter.js
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
modules/relevatehealthBidAdapter.jshas 13 duplicated lines withlibraries/audiencelogyUtils/bidderUtils.jsmodules/relevatehealthBidAdapter.jshas 21 duplicated lines withlibraries/audiencelogyUtils/bidderUtils.jsmodules/deepintentBidAdapter.jshas 6 duplicated lines withlibraries/audiencelogyUtils/bidderUtils.jsmodules/audiencelogyBidAdapter.jshas 19 duplicated lines withmodules/relevatehealthBidAdapter.js
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
modules/relevatehealthBidAdapter.jshas 13 duplicated lines withlibraries/audiencelogyUtils/bidderUtils.jsmodules/relevatehealthBidAdapter.jshas 21 duplicated lines withlibraries/audiencelogyUtils/bidderUtils.jsmodules/deepintentBidAdapter.jshas 6 duplicated lines withlibraries/audiencelogyUtils/bidderUtils.jsmodules/audiencelogyBidAdapter.jshas 19 duplicated lines withmodules/relevatehealthBidAdapter.js
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀
@patmmccann I have added library audiencelogyUtils/bidderUtils.js and imported common code. Please verify.
@hasanideepak yes but you should also import in relevate, which has the same concern above, it uses local storage without importing storage manager
@hasanideepak yes but you should also import in relevate, which has the same concern above, it uses local storage without importing storage manager
There are two different fork repo for relevate and audiencelogy. I will need to add same library in relevate fork in order to use it, doesnt that give conflict error as same code will be there in audiencelogy and relevate? I tried using storage manager, but it was unable to read the value from local storage. Can you please let me know some example.
I will need to add same library in relevate fork in order to use it, doesnt that give conflict error as same code will be there in audiencelogy and relevate?
both will import it, but the build will be more compact as the code will only be in the project once. It will clear the error.
tried using storage manager, but it was unable to read the value from local storage. Can you please let me know some example.
https://github.com/prebid/Prebid.js/blob/ca24c395555167e5aba7007a83332c1d49441921/modules/ixBidAdapter.js#L110
What you have in relevate is a major rules violation, as it ignores consent. We need you to take care of it in this commit. I'll go ahead and submit a bug fix to delete what you are doing there now, so you'll want to merge in master after that merges to avoid merge conflicts
I will need to add same library in relevate fork in order to use it, doesnt that give conflict error as same code will be there in audiencelogy and relevate?
both will import it, but the build will be more compact as the code will only be in the project once. It will clear the error.
tried using storage manager, but it was unable to read the value from local storage. Can you please let me know some example.
https://github.com/prebid/Prebid.js/blob/ca24c395555167e5aba7007a83332c1d49441921/modules/ixBidAdapter.js#L110
What you have in relevate is a major rules violation, as it ignores consent. We need you to take care of it in this commit. I'll go ahead and submit a bug fix to delete what you are doing there now, so you'll want to merge in master after that merges to avoid merge conflicts
@patmmccann Thank you for the support. So, I will make the changes for store manager in this PR (i.e.audiencelogy) and create a new PR for relevate adapter to import common library and store manager changes. Is this right ? Merging both PR wont cause any conflicts ?
@patmmccann Considering we are an ad tech service provider to relevate and we also need our own prebid adapter, we would like to focus on relevate adapter at this moment to make it fully compliant with your policies (with storage manager changes), hence we would like to pause work on our own adapter (i.e. audiencelogy) at this moment and we will revisit in a few weeks. Thank you for your support
No worries, just import storage manager instead of directly accessing local storage, keeping an eye out for your commit