Prebid.js icon indicating copy to clipboard operation
Prebid.js copied to clipboard

minBidCacheTTL better memory optimization

Open andyblackwell opened this issue 1 year ago • 3 comments

Type of issue

feature request

Description

currently minBidCacheTTL is applied at the auction level, so if you get a single bid with a long TTL, like an hour, then all the bids in the auction stay around for the full hour https://github.com/prebid/Prebid.js/blob/4577159c0ec31896e5e0bd7654638861a265c189/src/auctionManager.js#L43-L48

any reason we couldn't remove bids as they expire directly, in the auction object? https://github.com/prebid/Prebid.js/blob/4577159c0ec31896e5e0bd7654638861a265c189/src/auction.js#L156

could leave the auction-level removal as well, as that also frees up memory from all the other stored info in an auction like: requests, nobids, non bids, winning bids, etc

Other information

#10308

andyblackwell avatar Apr 09 '24 19:04 andyblackwell

@andyblackwell great Idea! Does aditude plan to submit the fix?

patmmccann avatar Apr 17 '24 00:04 patmmccann

Talked about this, we think a behavior change would likely not break anyone and we likely do not need additional configuration for this behavior. It seems to be a welcomed change.

patmmccann avatar Apr 22 '24 15:04 patmmccann

@patmmccann How about this ^

fowler446 avatar Jun 12 '24 14:06 fowler446