Prebid.js icon indicating copy to clipboard operation
Prebid.js copied to clipboard

getConfig cleanup of consent management

Open patmmccann opened this issue 2 years ago • 2 comments

This is a serious bug in several adapters. Consent management needs to come off the request.

https://github.com/prebid/Prebid.js/blob/56292c4672a0b19bee34840dca93bd3e1e5b8afe/modules/aidemBidAdapter.js#L111 https://github.com/prebid/Prebid.js/blob/56292c4672a0b19bee34840dca93bd3e1e5b8afe/modules/apstreamBidAdapter.js#L295 https://github.com/prebid/Prebid.js/blob/56292c4672a0b19bee34840dca93bd3e1e5b8afe/modules/sirdataRtdProvider.js#L85 https://github.com/prebid/Prebid.js/blob/56292c4672a0b19bee34840dca93bd3e1e5b8afe/modules/madvertiseBidAdapter.js#L56

patmmccann avatar Oct 30 '23 14:10 patmmccann

@RemiSirdata @gsollazzo @darkstarac please take a look

patmmccann avatar Jan 11 '24 19:01 patmmccann

@patmmccann Hello Patrick. Sorry to bother you, but it's not very clear to us what fix is needed. Have you got some suggestions on this issue ?

darkstarac avatar Feb 08 '24 14:02 darkstarac

@patmmccann Hello Patrick ? Any hint on this issue ? As asked before we some clarification about the problem.

darkstarac avatar May 15 '24 08:05 darkstarac

@darkstarac consent should not come from a getConfig call. You should only need to access the request object

patmmccann avatar May 21 '24 12:05 patmmccann

This is a serious bug in several adapters. Consent management needs to come off the request.

https://github.com/prebid/Prebid.js/blob/56292c4672a0b19bee34840dca93bd3e1e5b8afe/modules/aidemBidAdapter.js#L111

https://github.com/prebid/Prebid.js/blob/56292c4672a0b19bee34840dca93bd3e1e5b8afe/modules/apstreamBidAdapter.js#L295

https://github.com/prebid/Prebid.js/blob/56292c4672a0b19bee34840dca93bd3e1e5b8afe/modules/sirdataRtdProvider.js#L85

https://github.com/prebid/Prebid.js/blob/56292c4672a0b19bee34840dca93bd3e1e5b8afe/modules/madvertiseBidAdapter.js#L56 This has been fix sor sirdata RTD Module, please see https://github.com/prebid/Prebid.js/pull/11524. Thanks !

nouchy avatar May 22 '24 07:05 nouchy