signals
signals copied to clipboard
Throw error when binding signal to event handler
Resolves #607
đĻ Changeset detected
Latest commit: 3f10a8fe6d57061c4b7c5c71ea48b8b099b07af7
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| @preact/signals | Minor |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Deploy Preview for preact-signals-demo ready!
| Name | Link |
|---|---|
| Latest commit | 3f10a8fe6d57061c4b7c5c71ea48b8b099b07af7 |
| Latest deploy log | https://app.netlify.com/sites/preact-signals-demo/deploys/670569469022570008618717 |
| Deploy Preview | https://deploy-preview-610--preact-signals-demo.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Size Change: +228 B (+0.27%)
Total Size: 83.5 kB
| Filename | Size | Change | |
|---|---|---|---|
docs/dist/assets/bench.********.js |
1.59 kB | +2 B (+0.13%) | |
docs/dist/assets/index.********.js |
836 B | +1 B (+0.12%) | |
docs/dist/assets/signals.module.********.js |
2.16 kB | +77 B (+3.7%) | |
docs/dist/basic-********.js |
244 B | +1 B (+0.41%) | |
docs/dist/demos-********.js |
3.45 kB | +1 B (+0.03%) | |
packages/preact/dist/signals.js |
1.43 kB | +74 B (+5.47%) | đ |
packages/preact/dist/signals.mjs |
1.38 kB | +72 B (+5.53%) | đ |
âšī¸ View Unchanged
| Filename | Size |
|---|---|
docs/dist/assets/client.********.js |
46.3 kB |
docs/dist/assets/jsxRuntime.module.********.js |
284 B |
docs/dist/assets/preact.module.********.js |
4.03 kB |
docs/dist/assets/signals-core.module.********.js |
1.41 kB |
docs/dist/assets/style.********.js |
21 B |
docs/dist/assets/style.********.css |
1.24 kB |
docs/dist/nesting-********.js |
1.13 kB |
docs/dist/react-********.js |
243 B |
packages/core/dist/signals-core.js |
1.45 kB |
packages/core/dist/signals-core.mjs |
1.47 kB |
packages/react-transform/dist/signals-*********.js |
5.03 kB |
packages/react-transform/dist/signals-transform.mjs |
4.27 kB |
packages/react-transform/dist/signals-transform.umd.js |
5.15 kB |
packages/react/dist/signals.js |
188 B |
packages/react/dist/signals.mjs |
150 B |
Sorry, had somehow missed this PR. Seems reasonable, though I wish we had a better detection method than starting with 'on' (totally aware this is what Preact does too, matching it makes sense)
@rschristian no worries, yes my main reason for removing this is that the detection is flawed and we could in theory start using handleEvent as well to capture these đ
though that would only be supported in 10.25.0