signals icon indicating copy to clipboard operation
signals copied to clipboard

Change delay to double microtask for prop updates

Open JoviDeCroock opened this issue 1 year ago â€ĸ 3 comments

This changes the delay for property updates to be a double micro-task, we got a report that in examples like

const App = () => {
  const text = useSignal('')
  const style = useSignal('')

  const callback = (input) => {
    text.value = input.currentTarget.value
    if (text.value >= 5) { style.value = 'display:none;'}
  }

  return <input style={style} onInput={callback} value={text} />
}

In the above case the user would be able to type 6 characters while we have actually already made the input dissapear.

JoviDeCroock avatar Oct 08 '24 14:10 JoviDeCroock

đŸĻ‹ Changeset detected

Latest commit: ccdba1b6d1556fae823fc38b55715fcb440c2204

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@preact/signals Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Oct 08 '24 14:10 changeset-bot[bot]

Deploy Preview for preact-signals-demo ready!

Name Link
Latest commit ccdba1b6d1556fae823fc38b55715fcb440c2204
Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/6752ffc34a00d500080ba91e
Deploy Preview https://deploy-preview-609--preact-signals-demo.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Oct 08 '24 14:10 netlify[bot]

Size Change: +316 B (+0.38%)

Total Size: 83.6 kB

Filename Size Change
docs/dist/assets/index.********.js 836 B +1 B (+0.12%)
docs/dist/assets/signals.module.********.js 2.16 kB +74 B (+3.55%)
packages/preact/dist/signals.js 1.46 kB +111 B (+8.21%) 🔍
packages/preact/dist/signals.mjs 1.43 kB +130 B (+9.98%) âš ī¸
â„šī¸ View Unchanged
Filename Size
docs/dist/assets/bench.********.js 1.59 kB
docs/dist/assets/client.********.js 46.4 kB
docs/dist/assets/jsxRuntime.module.********.js 284 B
docs/dist/assets/preact.module.********.js 4.03 kB
docs/dist/assets/signals-core.module.********.js 1.41 kB
docs/dist/assets/style.********.js 21 B
docs/dist/assets/style.********.css 1.24 kB
docs/dist/basic-********.js 243 B
docs/dist/demos-********.js 3.44 kB
docs/dist/nesting-********.js 1.13 kB
docs/dist/react-********.js 242 B
packages/core/dist/signals-core.js 1.45 kB
packages/core/dist/signals-core.mjs 1.47 kB
packages/react-transform/dist/signals-*********.js 5.03 kB
packages/react-transform/dist/signals-transform.mjs 4.27 kB
packages/react-transform/dist/signals-transform.umd.js 5.15 kB
packages/react/dist/signals.js 188 B
packages/react/dist/signals.mjs 150 B

compressed-size-action

github-actions[bot] avatar Oct 08 '24 14:10 github-actions[bot]