signals icon indicating copy to clipboard operation
signals copied to clipboard

Remove Signal.prototype.toString

Open jviide opened this issue 2 years ago • 3 comments

This pull request removes the Signal.prototype.toString method. This is based on discussion on the Preact Slack, where there was no 100% certainty for this change yet, so feel free to close this PR if toString is deemed necessary.

jviide avatar Sep 20 '22 21:09 jviide

⚠️ No Changeset found

Latest commit: 8b05432975e25fd58f2308443b33101f746fceb9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Sep 20 '22 21:09 changeset-bot[bot]

Deploy Preview for preact-signals-demo ready!

Name Link
Latest commit 8b05432975e25fd58f2308443b33101f746fceb9
Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/632a2f1500e25b0008be41cb
Deploy Preview https://deploy-preview-193--preact-signals-demo.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Sep 20 '22 21:09 netlify[bot]

Size Change: -39 B (0%)

Total Size: 67.4 kB

Filename Size Change
docs/dist/assets/index.********.js 1.08 kB +1 B (0%)
docs/dist/assets/signals-core.module.********.js 1.31 kB -14 B (-1%)
docs/dist/assets/signals.module.********.js 1.96 kB -1 B (0%)
docs/dist/basic-********.js 246 B +2 B (+1%)
docs/dist/demos-********.js 3.35 kB +2 B (0%)
packages/core/dist/signals-core.js 1.38 kB -14 B (-1%)
packages/core/dist/signals-core.mjs 1.41 kB -15 B (-1%)
ℹ️ View Unchanged
Filename Size
docs/dist/assets/client.********.js 45.8 kB
docs/dist/assets/jsxRuntime.module.********.js 282 B
docs/dist/assets/preact.module.********.js 4 kB
docs/dist/assets/style.********.js 21 B
docs/dist/assets/style.********.css 1.21 kB
docs/dist/nesting-********.js 1.13 kB
docs/dist/react-********.js 240 B
packages/preact/dist/signals.js 1.18 kB
packages/preact/dist/signals.mjs 1.15 kB
packages/react/dist/signals.js 833 B
packages/react/dist/signals.mjs 810 B

compressed-size-action

github-actions[bot] avatar Sep 20 '22 21:09 github-actions[bot]

.toString() is useful for things like tagged template strings. Closing this.

jviide avatar Mar 13 '24 12:03 jviide