preact
preact copied to clipboard
Fix event proxy exception
Prevent event proxy functions from throwing exceptions in the rare case _listeners is not set
Fixes issue #3218
📊 Tachometer Benchmark Results
Summary
duration
- 02_replace1k: unsure 🔍 -3% - +3% (-3.44ms - +3.46ms)
preact-local vs preact-master - 03_update10th1k_x16: unsure 🔍 -5% - +4% (-2.45ms - +2.21ms)
preact-local vs preact-master - 07_create10k: unsure 🔍 -1% - +1% (-13.19ms - +8.64ms)
preact-local vs preact-master - filter_list: unsure 🔍 -1% - +4% (-0.25ms - +1.21ms)
preact-local vs preact-master - hydrate1k: unsure 🔍 -2% - +6% (-3.59ms - +11.77ms)
preact-local vs preact-master - many_updates: unsure 🔍 -5% - +3% (-1.01ms - +0.61ms)
preact-local vs preact-master - text_update: unsure 🔍 -3% - +5% (-0.07ms - +0.14ms)
preact-local vs preact-master
usedJSHeapSize
- 02_replace1k: unsure 🔍 -0% - +1% (-0.01ms - +0.03ms)
preact-local vs preact-master - 03_update10th1k_x16: unsure 🔍 -1% - +0% (-0.03ms - +0.02ms)
preact-local vs preact-master - 07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
preact-local vs preact-master - filter_list: unsure 🔍 -2% - +1% (-0.04ms - +0.01ms)
preact-local vs preact-master - hydrate1k: unsure 🔍 -0% - +1% (-0.01ms - +0.05ms)
preact-local vs preact-master - many_updates: unsure 🔍 -0% - +0% (-0.02ms - +0.01ms)
preact-local vs preact-master - text_update: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
preact-local vs preact-master
Results
02_replace1k
- Browser: chrome-headless 98.0.4758.102
- Sample size: 80
- Built by: Benchmarks #698
-
Commit: a5bb7de
duration
Version | Avg time | vs preact-master | vs preact-local |
---|---|---|---|
preact-master | 125.34ms - 130.35ms | - | unsure 🔍 -3% - +3% -3.46ms - +3.44ms |
preact-local | 125.49ms - 130.22ms | unsure 🔍 -3% - +3% -3.44ms - +3.46ms | - |
usedJSHeapSize
Version | Avg time | vs preact-master | vs preact-local |
---|---|---|---|
preact-master | 3.55ms - 3.58ms | - | unsure 🔍 -1% - +0% -0.03ms - +0.01ms |
preact-local | 3.56ms - 3.60ms | unsure 🔍 -0% - +1% -0.01ms - +0.03ms | - |
run-warmup-0
Version | Avg time | vs preact-master | vs preact-local |
---|---|---|---|
preact-master | 49.23ms - 51.01ms | - | unsure 🔍 -3% - +2% -1.40ms - +1.05ms |
preact-local | 49.45ms - 51.14ms | unsure 🔍 -2% - +3% -1.05ms - +1.40ms | - |
run-warmup-1
Version | Avg time | vs preact-master | vs preact-local |
---|---|---|---|
preact-master | 71.30ms - 75.07ms | - | unsure 🔍 -5% - +1% -3.57ms - +1.01ms |
preact-local | 73.16ms - 75.76ms | unsure 🔍 -1% - +5% -1.01ms - +3.57ms | - |
run-warmup-2
Version | Avg time | vs preact-master | vs preact-local |
---|---|---|---|
preact-master | 56.98ms - 63.93ms | - | unsure 🔍 -10% - +6% -6.22ms - +3.61ms |
preact-local | 58.27ms - 65.24ms | unsure 🔍 -6% - +10% -3.61ms - +6.22ms | - |
run-warmup-3
Version | Avg time | vs preact-master | vs preact-local |
---|---|---|---|
preact-master | 51.09ms - 57.63ms | - | unsure 🔍 -8% - +10% -4.10ms - +5.31ms |
preact-local | 50.37ms - 57.14ms | unsure 🔍 -10% - +7% -5.31ms - +4.10ms | - |
run-warmup-4
Version | Avg time | vs preact-master | vs preact-local |
---|---|---|---|
preact-master | 68.55ms - 71.88ms | - | unsure 🔍 -3% - +5% -1.78ms - +3.29ms |
preact-local | 67.55ms - 71.37ms | unsure 🔍 -5% - +3% -3.29ms - +1.78ms | - |
run-final
Version | Avg time | vs preact-master | vs preact-local |
---|---|---|---|
preact-master | 43.03ms - 46.26ms | - | unsure 🔍 -5% - +5% -2.04ms - +2.43ms |
preact-local | 42.90ms - 46.00ms | unsure 🔍 -5% - +5% -2.43ms - +2.04ms | - |
03_update10th1k_x16
- Browser: chrome-headless 98.0.4758.102
- Sample size: 50
- Built by: Benchmarks #698
-
Commit: a5bb7de
duration
Version | Avg time | vs preact-master | vs preact-local |
---|---|---|---|
preact-master | 52.13ms - 55.59ms | - | unsure 🔍 -4% - +5% -2.21ms - +2.45ms |
preact-local | 52.19ms - 55.30ms | unsure 🔍 -5% - +4% -2.45ms - +2.21ms | - |
usedJSHeapSize
Version | Avg time | vs preact-master | vs preact-local |
---|---|---|---|
preact-master | 3.45ms - 3.48ms | - | unsure 🔍 -0% - +1% -0.02ms - +0.03ms |
preact-local | 3.44ms - 3.47ms | unsure 🔍 -1% - +0% -0.03ms - +0.02ms | - |
07_create10k
- Browser: chrome-headless 98.0.4758.102
- Sample size: 50
- Built by: Benchmarks #698
-
Commit: a5bb7de
duration
Version | Avg time | vs preact-master | vs preact-local |
---|---|---|---|
preact-master | 1454.96ms - 1470.66ms | - | unsure 🔍 -1% - +1% -8.64ms - +13.19ms |
preact-local | 1452.95ms - 1468.12ms | unsure 🔍 -1% - +1% -13.19ms - +8.64ms | - |
usedJSHeapSize
Version | Avg time | vs preact-master | vs preact-local |
---|---|---|---|
preact-master | 25.36ms - 25.36ms | - | unsure 🔍 -0% - +0% -0.00ms - +0.00ms |
preact-local | 25.36ms - 25.36ms | unsure 🔍 -0% - +0% -0.00ms - +0.00ms | - |
filter_list
- Browser: chrome-headless 98.0.4758.102
- Sample size: 70
- Built by: Benchmarks #698
-
Commit: a5bb7de
duration
Version | Avg time | vs preact-master | vs preact-local |
---|---|---|---|
preact-master | 28.03ms - 29.05ms | - | unsure 🔍 -4% - +1% -1.21ms - +0.25ms |
preact-local | 28.50ms - 29.54ms | unsure 🔍 -1% - +4% -0.25ms - +1.21ms | - |
usedJSHeapSize
Version | Avg time | vs preact-master | vs preact-local |
---|---|---|---|
preact-master | 1.62ms - 1.66ms | - | unsure 🔍 -1% - +2% -0.01ms - +0.04ms |
preact-local | 1.61ms - 1.64ms | unsure 🔍 -2% - +1% -0.04ms - +0.01ms | - |
hydrate1k
- Browser: chrome-headless 98.0.4758.102
- Sample size: 80
- Built by: Benchmarks #698
-
Commit: a5bb7de
duration
Version | Avg time | vs preact-master | vs preact-local |
---|---|---|---|
preact-master | 194.19ms - 206.23ms | - | unsure 🔍 -6% - +2% -11.77ms - +3.59ms |
preact-local | 199.53ms - 209.07ms | unsure 🔍 -2% - +6% -3.59ms - +11.77ms | - |
usedJSHeapSize
Version | Avg time | vs preact-master | vs preact-local |
---|---|---|---|
preact-master | 6.21ms - 6.25ms | - | unsure 🔍 -1% - +0% -0.05ms - +0.01ms |
preact-local | 6.22ms - 6.27ms | unsure 🔍 -0% - +1% -0.01ms - +0.05ms | - |
many_updates
- Browser: chrome-headless 98.0.4758.102
- Sample size: 50
- Built by: Benchmarks #698
-
Commit: a5bb7de
duration
Version | Avg time | vs preact-master | vs preact-local |
---|---|---|---|
preact-master | 21.71ms - 22.84ms | - | unsure 🔍 -3% - +5% -0.61ms - +1.01ms |
preact-local | 21.49ms - 22.66ms | unsure 🔍 -5% - +3% -1.01ms - +0.61ms | - |
usedJSHeapSize
Version | Avg time | vs preact-master | vs preact-local |
---|---|---|---|
preact-master | 4.65ms - 4.67ms | - | unsure 🔍 -0% - +0% -0.01ms - +0.02ms |
preact-local | 4.65ms - 4.66ms | unsure 🔍 -0% - +0% -0.02ms - +0.01ms | - |
text_update
- Browser: chrome-headless 98.0.4758.102
- Sample size: 90
- Built by: Benchmarks #698
-
Commit: a5bb7de
duration
Version | Avg time | vs preact-master | vs preact-local |
---|---|---|---|
preact-master | 2.82ms - 2.97ms | - | unsure 🔍 -5% - +2% -0.14ms - +0.07ms |
preact-local | 2.85ms - 3.01ms | unsure 🔍 -3% - +5% -0.07ms - +0.14ms | - |
usedJSHeapSize
Version | Avg time | vs preact-master | vs preact-local |
---|---|---|---|
preact-master | 0.82ms - 0.82ms | - | unsure 🔍 -0% - -0% -0.00ms - -0.00ms |
preact-local | 0.82ms - 0.82ms | unsure 🔍 +0% - +0% +0.00ms - +0.00ms | - |
Coverage remained the same at 99.625% when pulling a5bb7de5b684859fc6dee6bafe9fa98d8eed187d on michael-graves-dojo:master into d4a301391c21632828a1a9c19e08486a18075974 on preactjs:master.
Any updates here? The fix seems sane.