preact icon indicating copy to clipboard operation
preact copied to clipboard

set null for custom elements

Open JoviDeCroock opened this issue 2 years ago • 3 comments

Fixes https://github.com/preactjs/preact/issues/3276

JoviDeCroock avatar Oct 10 '21 12:10 JoviDeCroock

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -3% - +2% (-4.28ms - +3.25ms)
    preact-local vs preact-master
  • 02_replace1k: 148.82ms - 159.09ms
  • 03_update10th1k_x16: unsure 🔍 -5% - +5% (-1.98ms - +1.96ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: 53.54ms - 56.56ms
  • 07_create10k: unsure 🔍 -3% - +1% (-51.24ms - +10.22ms)
    preact-local vs preact-master
  • 07_create10k: 1398.91ms - 1407.07ms
  • filter_list: unsure 🔍 -10% - +12% (-7.09ms - +8.71ms)
    preact-local vs preact-master
  • filter_list: 35.62ms - 40.39ms
  • hydrate1k: unsure 🔍 -1% - +2% (-1.88ms - +2.72ms)
    preact-local vs preact-master
  • hydrate1k: 173.45ms - 181.47ms
  • many_updates: unsure 🔍 -11% - +3% (-10.04ms - +2.60ms)
    preact-local vs preact-master
  • many_updates: 83.60ms - 98.87ms
  • text_update: slower ❌ 1% - 6% (0.04ms - 0.17ms)
    preact-local vs preact-master
  • text_update: 2.68ms - 2.75ms

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +0% (-0.02ms - +0.01ms)
    preact-local vs preact-master
  • 02_replace1k: 3.76ms - 3.78ms
  • 03_update10th1k_x16: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: 3.65ms - 3.65ms
  • 07_create10k: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-master
  • 07_create10k: 25.59ms - 25.59ms
  • filter_list: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-master
  • filter_list: 1.81ms - 1.81ms
  • hydrate1k: unsure 🔍 -0% - +0% (-0.03ms - +0.02ms)
    preact-local vs preact-master
  • hydrate1k: 6.41ms - 6.43ms
  • many_updates: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-master
  • many_updates: 4.87ms - 4.87ms
  • text_update: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-master
  • text_update: 1.05ms - 1.05ms

Results

02_replace1k
  • Browser: chrome-headless 102.0.5005.115
  • Sample size: 80
  • Built by: Benchmarks #801
  • Commit: 8fc6dc6

duration

VersionAvg timevs preact-mastervs preact-local
preact-master137.39ms - 143.24ms-unsure 🔍
-2% - +3%
-3.25ms - +4.28ms
preact-local137.42ms - 142.18msunsure 🔍
-3% - +2%
-4.28ms - +3.25ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.76ms - 3.78ms-unsure 🔍
-0% - +0%
-0.01ms - +0.02ms
preact-local3.76ms - 3.77msunsure 🔍
-0% - +0%
-0.02ms - +0.01ms
-

run-warmup-0

VersionAvg timevs preact-mastervs preact-local
preact-master46.85ms - 47.79ms-faster ✔
0% - 3%
0.19ms - 1.60ms
preact-local47.69ms - 48.74msslower ❌
0% - 3%
0.19ms - 1.60ms
-

run-warmup-1

VersionAvg timevs preact-mastervs preact-local
preact-master65.94ms - 68.87ms-faster ✔
0% - 7%
0.23ms - 4.94ms
preact-local68.15ms - 71.83msslower ❌
0% - 7%
0.23ms - 4.94ms
-

run-warmup-2

VersionAvg timevs preact-mastervs preact-local
preact-master53.40ms - 57.98ms-unsure 🔍
-4% - +7%
-2.42ms - +3.81ms
preact-local52.88ms - 57.11msunsure 🔍
-7% - +4%
-3.81ms - +2.42ms
-

run-warmup-3

VersionAvg timevs preact-mastervs preact-local
preact-master55.04ms - 60.26ms-unsure 🔍
-9% - +3%
-5.58ms - +1.98ms
preact-local56.72ms - 62.18msunsure 🔍
-4% - +10%
-1.98ms - +5.58ms
-

run-warmup-4

VersionAvg timevs preact-mastervs preact-local
preact-master102.06ms - 112.21ms-unsure 🔍
-7% - +6%
-7.80ms - +6.92ms
preact-local102.24ms - 112.90msunsure 🔍
-6% - +7%
-6.92ms - +7.80ms
-

run-final

VersionAvg timevs preact-mastervs preact-local
preact-master39.71ms - 42.45ms-unsure 🔍
-6% - +4%
-2.40ms - +1.52ms
preact-local40.11ms - 42.92msunsure 🔍
-4% - +6%
-1.52ms - +2.40ms
-
02_replace1k
  • Browser: chrome-headless 102.0.5005.115
  • Sample size: 100
  • Built by: Benchmarks #800
  • Commit: 8fc6dc6

duration

VersionAvg timevs
148.82ms - 159.09ms-

usedJSHeapSize

VersionAvg timevs
3.76ms - 3.78ms-

run-warmup-0

VersionAvg timevs
47.02ms - 48.50ms-

run-warmup-1

VersionAvg timevs
73.90ms - 78.33ms-

run-warmup-2

VersionAvg timevs
56.17ms - 60.91ms-

run-warmup-3

VersionAvg timevs
61.67ms - 65.69ms-

run-warmup-4

VersionAvg timevs
114.92ms - 124.84ms-

run-final

VersionAvg timevs
44.14ms - 47.60ms-
03_update10th1k_x16
  • Browser: chrome-headless 102.0.5005.115
  • Sample size: 50
  • Built by: Benchmarks #801
  • Commit: 8fc6dc6

duration

VersionAvg timevs preact-mastervs preact-local
preact-master38.98ms - 41.44ms-unsure 🔍
-5% - +5%
-1.96ms - +1.98ms
preact-local38.66ms - 41.74msunsure 🔍
-5% - +5%
-1.98ms - +1.96ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.65ms - 3.65ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-local3.65ms - 3.65msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms
-
03_update10th1k_x16
  • Browser: chrome-headless 102.0.5005.115
  • Sample size: 50
  • Built by: Benchmarks #800
  • Commit: 8fc6dc6

duration

VersionAvg timevs
53.54ms - 56.56ms-

usedJSHeapSize

VersionAvg timevs
3.65ms - 3.65ms-
07_create10k
  • Browser: chrome-headless 102.0.5005.115
  • Sample size: 50
  • Built by: Benchmarks #801
  • Commit: 8fc6dc6

duration

VersionAvg timevs preact-mastervs preact-local
preact-master1603.43ms - 1661.78ms-unsure 🔍
-1% - +3%
-10.22ms - +51.24ms
preact-local1602.43ms - 1621.74msunsure 🔍
-3% - +1%
-51.24ms - +10.22ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master25.59ms - 25.59ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-local25.59ms - 25.59msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms
-
07_create10k
  • Browser: chrome-headless 102.0.5005.115
  • Sample size: 50
  • Built by: Benchmarks #800
  • Commit: 8fc6dc6

duration

VersionAvg timevs
1398.91ms - 1407.07ms-

usedJSHeapSize

VersionAvg timevs
25.59ms - 25.59ms-
filter_list
  • Browser: chrome-headless 102.0.5005.115
  • Sample size: 70
  • Built by: Benchmarks #801
  • Commit: 8fc6dc6

duration

VersionAvg timevs preact-mastervs preact-local
preact-master67.17ms - 78.72ms-unsure 🔍
-12% - +10%
-8.71ms - +7.09ms
preact-local68.37ms - 79.15msunsure 🔍
-10% - +12%
-7.09ms - +8.71ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.81ms - 1.81ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-local1.81ms - 1.81msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms
-
filter_list
  • Browser: chrome-headless 102.0.5005.115
  • Sample size: 50
  • Built by: Benchmarks #800
  • Commit: 8fc6dc6

duration

VersionAvg timevs
35.62ms - 40.39ms-

usedJSHeapSize

VersionAvg timevs
1.81ms - 1.81ms-
hydrate1k
  • Browser: chrome-headless 102.0.5005.115
  • Sample size: 50
  • Built by: Benchmarks #801
  • Commit: 8fc6dc6

duration

VersionAvg timevs preact-mastervs preact-local
preact-master125.52ms - 128.77ms-unsure 🔍
-2% - +1%
-2.72ms - +1.88ms
preact-local125.94ms - 129.20msunsure 🔍
-1% - +2%
-1.88ms - +2.72ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master6.43ms - 6.46ms-unsure 🔍
-0% - +0%
-0.02ms - +0.03ms
preact-local6.42ms - 6.45msunsure 🔍
-0% - +0%
-0.03ms - +0.02ms
-
hydrate1k
  • Browser: chrome-headless 102.0.5005.115
  • Sample size: 50
  • Built by: Benchmarks #800
  • Commit: 8fc6dc6

duration

VersionAvg timevs
173.45ms - 181.47ms-

usedJSHeapSize

VersionAvg timevs
6.41ms - 6.43ms-
many_updates
  • Browser: chrome-headless 102.0.5005.115
  • Sample size: 70
  • Built by: Benchmarks #801
  • Commit: 8fc6dc6

duration

VersionAvg timevs preact-mastervs preact-local
preact-master81.64ms - 91.61ms-unsure 🔍
-3% - +12%
-2.60ms - +10.04ms
preact-local79.02ms - 86.79msunsure 🔍
-11% - +3%
-10.04ms - +2.60ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.87ms - 4.87ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-local4.87ms - 4.87msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms
-
many_updates
  • Browser: chrome-headless 102.0.5005.115
  • Sample size: 50
  • Built by: Benchmarks #800
  • Commit: 8fc6dc6

duration

VersionAvg timevs
83.60ms - 98.87ms-

usedJSHeapSize

VersionAvg timevs
4.87ms - 4.87ms-
text_update
  • Browser: chrome-headless 102.0.5005.115
  • Sample size: 260
  • Built by: Benchmarks #801
  • Commit: 8fc6dc6

duration

VersionAvg timevs preact-mastervs preact-local
preact-master3.00ms - 3.07ms-faster ✔
1% - 5%
0.04ms - 0.17ms
preact-local3.08ms - 3.20msslower ❌
1% - 6%
0.04ms - 0.17ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.04ms - 1.04ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-local1.05ms - 1.05msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms
-
text_update
  • Browser: chrome-headless 102.0.5005.115
  • Sample size: 50
  • Built by: Benchmarks #800
  • Commit: 8fc6dc6

duration

VersionAvg timevs
2.68ms - 2.75ms-

usedJSHeapSize

VersionAvg timevs
1.05ms - 1.05ms-

tachometer-reporter-action v2 for Benchmarks

github-actions[bot] avatar Oct 10 '21 12:10 github-actions[bot]

Size Change: +62 B (0%)

Total Size: 42.9 kB

Filename Size Change
dist/preact.js 4.05 kB +19 B (0%)
dist/preact.min.js 4.08 kB +14 B (0%)
dist/preact.module.js 4.07 kB +16 B (0%)
dist/preact.umd.js 4.11 kB +13 B (0%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.48 kB 0 B
compat/dist/compat.module.js 3.46 kB 0 B
compat/dist/compat.umd.js 3.54 kB 0 B
debug/dist/debug.js 3.01 kB 0 B
debug/dist/debug.module.js 3 kB 0 B
debug/dist/debug.umd.js 3.09 kB 0 B
devtools/dist/devtools.js 231 B 0 B
devtools/dist/devtools.module.js 239 B 0 B
devtools/dist/devtools.umd.js 307 B 0 B
hooks/dist/hooks.js 1.23 kB 0 B
hooks/dist/hooks.module.js 1.25 kB 0 B
hooks/dist/hooks.umd.js 1.32 kB 0 B
jsx-runtime/dist/jsxRuntime.js 317 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 327 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 395 B 0 B
test-utils/dist/testUtils.js 444 B 0 B
test-utils/dist/testUtils.module.js 444 B 0 B
test-utils/dist/testUtils.umd.js 521 B 0 B

compressed-size-action

github-actions[bot] avatar Oct 10 '21 12:10 github-actions[bot]

Coverage Status

Coverage remained the same at 99.446% when pulling 8fc6dc6fe2b27839f113a7f7238d5871253e2c21 on set-null-custom-el into bc02039f9c75be73431b3bd201439310f56dfba7 on master.

coveralls avatar Oct 10 '21 13:10 coveralls

Closing due to inactivity

JoviDeCroock avatar Apr 24 '23 10:04 JoviDeCroock