preact-router icon indicating copy to clipboard operation
preact-router copied to clipboard

Published 20 hours ago • verified publisher icon preactjs

Rebase #100

Open laggingreflex opened this issue 6 years ago • 5 comments

Rebase #100 against current master

laggingreflex avatar Oct 05 '17 03:10 laggingreflex

Oh wow this is a lot of work, thanks a million. I noticed you published preact-router-nested to npm - are you successfully using this PR? That helps make sure it's good to go 👍

developit avatar Oct 05 '17 20:10 developit

Glad to help. I did use it but only very briefly, so can't vouch for it all that much, but it did seem to work as intended.

The reason I didn't use it very much was that I was finding it cumbersome in my personal use case, nesting all the routes in the layout I wanted. Then there's basePath and path props issues that you need to deal with, especially if you're also implementing a navigation to go along with all the nested routes. I created something different that suits my needs better: https://github.com/laggingreflex/dynamic-router, at least for now.

laggingreflex avatar Oct 06 '17 00:10 laggingreflex

@developit whats needed to get this or #100 merged?

rjmackay avatar Jan 18 '18 20:01 rjmackay

Just some thorough battle testing (or more unit tests?)

developit avatar Feb 11 '18 23:02 developit

Hi quickly updated - https://github.com/developit/preact-router/pull/293

matannoam-zz avatar Nov 09 '18 01:11 matannoam-zz