preact-cli icon indicating copy to clipboard operation
preact-cli copied to clipboard

sass-loader 8 incompatiblity

Open LeviSchuck opened this issue 6 years ago • 7 comments

Do you want to request a feature or report a bug? Bug

What is the current behaviour? Installing sass-loader results in the latest version (8.0.0) from NPM. then running npm run start which runs preact cli tools then fails with the following error

✖ ERROR ./node_modules/preact-cli/lib/lib/webpack/proxy-loader.js??ref--2-0!./src/components/formInput/style.scss
Module build failed: ValidationError: Invalid options object. Sass Loader has been initialised using an options object that does not match the API schema.
 - options has an unknown property 'includePaths'. These properties are valid:
   object { implementation?, sassOptions?, prependData?, sourceMap?, webpackImporter? }    at validate (/mnt./src/routes/category/index.js
 @ ./src/routes/category/index.js
 @ ./src/components/app.js
 @ ./src/index.js
 @ ./node_modules/preact-cli/lib/lib/entry.js
 @ multi ./node_modules/preact-cli/lib/lib/entry webpack-dev-server/client webpack/hot/dev-server

Note this hit vue at the same time https://github.com/vuejs/vue-cli/issues/4513

If the current behaviour is a bug, please provide the steps to reproduce. Create a new preact project, the demo with a header is fine. npm install [email protected] node-sass Rename the existing css file to a .scss file in one of the components. npm run start

What is the expected behaviour? Runs as usual, it works with [email protected] but not 8.0.0

If this is a feature request, what is motivation or use case for changing the behaviour? sass-loader seems to be officially listed in the documentation, maintaining support would be pleasant.

Please mention other relevant information.

Please paste the results of preact info here.

> preact info

         ▄▄ 
     ▄▄▓▓▓▓▓▓▄▄
  ▄█▀▀█▓▓▓▓▓▓▓▀▀█▄▄
▐▓▌▐▓▓▓▒▄ ▀▄▄▓▓▓▌▐▓▌
▐▓▓▄▀▓▀ ▄▓▓▄▄▀▓▓ ▓▓▌ 
▐▓▓▓▌ ▒▓▌  ▐▓▓  ▓▓▓▌ preact-cli 2.2.1
▐▓▓ ▒▓▄▄▀▓▓▀ ▄▓▓ ▓▓▌
▐▓▌▐▓▓▓▀▀▄▄▀▀▓▓▓▌▐▓▌
  ▀█▄▄▒▓▓▓▓▓▓▒▄▄▒▀
      ▀▓▓▓▓▓▓▀▀
         ▀▀
For help with a specific command, enter:
  preact help [command]

  create [template] [dest]  Create a new application.
  build [src] [dest]        Create a production build in build/
  watch [src]               Start a development live-reload server.
  serve [dir]               Start an HTTP2 static fileserver.
  list                      List all official templates

Options:
  -h, --help  Show help                                                [boolean]

Unknown argument: info

Is this an outdated command line option or issue template?

LeviSchuck avatar Aug 31 '19 23:08 LeviSchuck

Just commenting to confirm this behaviour in my project too. I'm not sure what change needs to be made here, however.

peabnuts123 avatar Sep 07 '19 23:09 peabnuts123

+1 Downgrading to [email protected] works.

lsahil avatar Sep 13 '19 10:09 lsahil

yarn add [email protected] and now it starts.

peterbe avatar Sep 26 '19 12:09 peterbe

Friendly ping - is anyone looking at this?

jliebrand avatar Nov 19 '19 20:11 jliebrand

Any update wrt this?

rajivkr avatar Apr 22 '20 06:04 rajivkr

Now because of Webpack 4 it's incompatible with sass-loader 11.

zgoda avatar Feb 07 '21 00:02 zgoda

It's working for me with [email protected], per the README.

kentr avatar Jan 13 '22 02:01 kentr

Closing, we've supported sass-loader v10+ for a while now and it's the best we can do on Webpack v4.

rschristian avatar Dec 23 '22 09:12 rschristian