preact-cli icon indicating copy to clipboard operation
preact-cli copied to clipboard

manifest.json extension change

Open pimdewit opened this issue 6 years ago • 2 comments

Do you want to request a feature or report a bug? A very nitpicky Feature

What is the current behaviour? preact-cli and its given templates seem to favour manifest.json over manifest.webmanifest. And it works great!

If the current behaviour is a bug, please provide the steps to reproduce. N/A

What is the expected behaviour? manifest.json to use the webmanifest extension (manifest.webmanifest)

If this is a feature request, what is motivation or use case for changing the behaviour? The W3 spec somewhat recently confirmed that they favour the webmanifest extension for app manifests

Please mention other relevant information. N/A

pimdewit avatar Feb 07 '19 12:02 pimdewit

Hey there ! Is this issue still wanted ?

If yes, i would be happy to discuss about how i was planing to do it here, before making a PR on it !

Sanix-Darker avatar Aug 04 '22 21:08 Sanix-Darker

Sure, if you wanted to implement I'd be happy to review and merge.

However, this should be in addition to the standard handling of manifest.json, not altering/replacing existing behavior. Even in a semver major, I'm rather against switching to .webmanifest due to the mime type issues that can arise (web servers might be unaware they need to serve that as application/manifest+json)

rschristian avatar Aug 04 '22 22:08 rschristian