pre-commit-hooks icon indicating copy to clipboard operation
pre-commit-hooks copied to clipboard

fixing the requirements-txt-fixer #960

Open j3962 opened this issue 2 years ago • 4 comments

Hey Anthony!

I have updated the requirements_txt_fixer.py to remove duplicate entries in the requirements file as per the bug in #960

Hope this helps! Jay

j3962 avatar Sep 27 '23 07:09 j3962

hi @JaySharmaSdsu -- you'll need to add a test to demonstrate your changes -- you'll also need to make sure the current testsuite continues to work

asottile avatar Sep 27 '23 13:09 asottile

Hmm, interesting! Let me do that then! Will ping you if I need any help. Those pytest file look confusing as a newbie!

j3962 avatar Sep 28 '23 05:09 j3962

hey @JaySharmaSdsu what is the status of this PR? can you please finish it?

csibe17 avatar Nov 08 '23 16:11 csibe17

Hey @csibe17! Sorry for the delay! I will make sure to finish it off before the end of this week!

Thank you for your patience!

j3962 avatar Nov 15 '23 03:11 j3962

this ended up getting solved in #1014

asottile avatar Apr 06 '24 18:04 asottile