pre-commit-hooks icon indicating copy to clipboard operation
pre-commit-hooks copied to clipboard

`requirements-txt-fixer` does not remove duplicated elements

Open csibe17 opened this issue 2 years ago • 5 comments

In requirements-txt-fixer if there are more than 1 requirement with the same params, the duplicates are not removed.

csibe17 avatar Sep 06 '23 11:09 csibe17

can you show an example?

asottile avatar Sep 06 '23 12:09 asottile

dependency1==1.0.0
dependency2==1.0.0
dependency3==1.0.0
dependency1==1.0.0

will end up as

dependency1==1.0.0
dependency1==1.0.0
dependency2==1.0.0
dependency3==1.0.0

csibe17 avatar Sep 06 '23 12:09 csibe17

I am totally new to contributing on open source. If this is indeed an issue. Can I work on it?'

j3962 avatar Sep 24 '23 22:09 j3962

sure go for it, let me know if you need any help

asottile avatar Sep 24 '23 22:09 asottile

Sick! Excited!! Let me get back if I need any help. I might be a bit slow, but I'll get it done for sure! Honestly, I don't understand much from the requirements-txt-fixer, but I'll learn it all. And I am so excited about the possibilities. This is gonna be so much fun! Thank you dude! @asottile can you assign the bug to me?

j3962 avatar Sep 24 '23 23:09 j3962