Blink icon indicating copy to clipboard operation
Blink copied to clipboard

Increase and decrease volume using scrollwheel

Open pypp opened this issue 1 year ago • 2 comments

Add the ability to increase and decrease the volume using the mouse wheel. resolves #312

pypp avatar May 14 '24 14:05 pypp

Thanks for your work but I will hold PRs for now

prayag17 avatar May 14 '24 14:05 prayag17

no problem.

pypp avatar May 14 '24 14:05 pypp

You can now fix the merge conflict

prayag17 avatar May 30 '24 12:05 prayag17

I get the following error when trying to connect to server

Error: Invalid hook call. Hooks can only be called inside of the body of a function component. This could happen for one of the following reasons: 1. You might have mismatching versions of React and the renderer (such as React DOM) 2. You might be breaking the Rules of Hooks 3. You might have more than one copy of React in the same app See https://reactjs.org/link/invalid-hook-call for tips about how to debug and fix this problem.

pypp avatar May 31 '24 05:05 pypp

Ig that issue is cause by useApiInContext I have used as the api context in tanstack router would update instantly like it should have. I will take a look at it

prayag17 avatar Jun 06 '24 04:06 prayag17

Hey @pypp, you can now rebase you PR. I will merge them as soon as you rebase

prayag17 avatar Jul 19 '24 16:07 prayag17

rebased.

pypp avatar Jul 20 '24 19:07 pypp

Thanks @pypp

prayag17 avatar Jul 21 '24 07:07 prayag17