prawn icon indicating copy to clipboard operation
prawn copied to clipboard
verified publisher icon prawnpdf

Fix spec failures for ruby 3.5

Open kbrock opened this issue 8 months ago • 2 comments

master is currently red. This turns it green.

If you have an alternate solution, please share.

fixes utf-8 vs us-ascii encoding for ruby 3.5-preview1

       expected: #<Encoding:UTF-8> "06ce69758c64b0e5f14d09474d94ba580aaa4edca7014c6ab5bc9536b5bb0d0c163425aceff74a0ad3867859f8372e07b96e63822cc0e789549bb3a35d3cf185"
            got: #<Encoding:US-ASCII> "4b7fb30d46e11bd6e65e49ea5a01e231be3800712729ca3d2843abd06c5333c7e80fbf5a168c4d3d9a84381424f4b2fcd18478517d47b9b33428168e0a2dfb60"

update: looks like render_file is not working. A proper fix will fix that and not gloss over it like this PR (changed to a draft)

kbrock avatar Apr 25 '25 21:04 kbrock

Did you have a chance to find what changed in 3.5 to make it go red?

pointlessone avatar Apr 26 '25 09:04 pointlessone

@pointlessone Good call. Yes, the output is not the same

At the very least, render_file is broken in ruby 3.5

SCR-20250428-qkdj

kbrock avatar Apr 28 '25 22:04 kbrock

I did not fix this. there is an actual underlying issue

kbrock avatar Oct 31 '25 15:10 kbrock