prawn icon indicating copy to clipboard operation
prawn copied to clipboard

Fix table headers

Open stormsilver opened this issue 8 years ago • 3 comments

Two things in this PR (I know, I know - I am bad and I feel bad)

  1. Since this change https://github.com/prawnpdf/prawn/pull/788 my table headers with valign: :bottom are too close to the bottom border (the bottoms of my g's and p's and y's and q's are touching that border. Mama always said to mind your p's and q's - I guess this is what she was talking about. She's a lot smarter than I ever gave her credit for when I was 16). It looks like originally final_gap was included in the fix but then removed because... something? Adding it back makes things look good again, but I don't know what other problems this could cause.
  2. Since this change https://github.com/prawnpdf/prawn/pull/963 my document margins aren't respected anymore. It turns out that the PR (accidentally?) changed from checking symbol options to checking string options. A single colon fixes the problem.

stormsilver avatar Dec 22 '16 17:12 stormsilver

@stormsilver Thank you for your contribution.

Could you please provide specs for the fixes so that these bugs would never come back?

pointlessone avatar Dec 22 '16 17:12 pointlessone

@pointlessone I added a spec for the margins fix, but I was really really really unsure how to test the vertical alignment. I poked around the tests from the original PR but they passed with or without my code change, which seemed... wrong.

stormsilver avatar Feb 16 '17 17:02 stormsilver

As pointed in https://github.com/prawnpdf/prawn/issues/1137#issuecomment-666525194, I believe this PR is likely stale and has already been integrated (https://github.com/prawnpdf/prawn/compare/2.2.0...2.2.1) via a separate commit if I'm not mistaken!

thbar avatar Jul 30 '20 17:07 thbar