praw icon indicating copy to clipboard operation
praw copied to clipboard

Window size config

Open Watchful1 opened this issue 2 years ago • 12 comments

Super bare bones initial implementation of passing a config value for window size into prawcore. Just wanted to have something down so I can feel like I started on it.

Watchful1 avatar Sep 22 '23 05:09 Watchful1

prawcore has been updated. Could you rebase and squash so the pipeline can run again?

LilSpazJoekp avatar Oct 01 '23 23:10 LilSpazJoekp

This PR is stale because it has been open for 30 days with no activity.

Remove the Stale label or comment or this will be closed in 30 days.

github-actions[bot] avatar Nov 08 '23 01:11 github-actions[bot]

Still planning on finishing this, just haven't had time recently.

Watchful1 avatar Nov 08 '23 02:11 Watchful1

This PR is stale because it has been open for 30 days with no activity.

Remove the Stale label or comment or this will be closed in 30 days.

github-actions[bot] avatar Dec 08 '23 06:12 github-actions[bot]

Bump, will have time for this over the holidays if not before.

Watchful1 avatar Dec 09 '23 01:12 Watchful1

This PR is stale because it has been open for 30 days with no activity.

Remove the Stale label or comment or this will be closed in 30 days.

github-actions[bot] avatar Jan 08 '24 06:01 github-actions[bot]

Bump

Watchful1 avatar Jan 09 '24 03:01 Watchful1

This PR is stale because it has been open for 30 days with no activity.

Remove the Stale label or comment or this will be closed in 30 days.

github-actions[bot] avatar Feb 08 '24 12:02 github-actions[bot]

Just checking in on this.

LilSpazJoekp avatar May 15 '24 14:05 LilSpazJoekp

It's still on my list, but pretty far at the bottom below other priorities. How much do you think it's actually needed? Reddit doesn't look like they are making any changes to the window size anytime soon.

Watchful1 avatar May 16 '24 01:05 Watchful1

Was waiting on doing a 8.0.0 release for this.

Would different paid tiers of rate limits make a difference in the rate limit calculation for optimal handling?

LilSpazJoekp avatar May 16 '24 02:05 LilSpazJoekp

Extremely unlikely they would have different window sizes. They just increase the requests per window. I imagine a lot of their infrastructure is built with the 10 minute window in mind.

Watchful1 avatar May 16 '24 02:05 Watchful1