zookeeper-operator icon indicating copy to clipboard operation
zookeeper-operator copied to clipboard

Make probes, commands and cm customisable

Open AdheipSingh opened this issue 2 years ago • 3 comments

Description

  • currently liveliness probes and readiness probes are hardcoded to execute scripts.

  • probes can be made customisable, same with the commands to execute the container.

  • I would be willing to submit a PR.

AdheipSingh avatar Sep 05 '22 20:09 AdheipSingh

Hey @AdheipSingh - If you use helm charts, then they are configurable via parameters

iampranabroy avatar Sep 24 '22 16:09 iampranabroy

Hey @AdheipSingh - If you use helm charts, then they are configurable via parameters

hi @iampranabroy,

yes, it is possible to set certain options, i.e. for read/liveness checks you can only change thresholds and duration but you can't replace the exec command. Would be useful to support fully customizable read/liveness probes if a different image is used and it has no scripts zookeeperReady.sh and zookeeperLive.sh available.

Screenshot 2022-10-14 at 9 50 27 AM

vladiceanu avatar Oct 14 '22 07:10 vladiceanu

The pod spec is hardcoded with a lot of configs. Ill send out a PR to make it configurable as per user.

@iampranabroy its hardcoded not customisable.

AdheipSingh avatar Oct 15 '22 18:10 AdheipSingh